[MDL-70037] Update mod_forum_get_discussion_posts web service to return the last_modified attribute - Moodle Tracker

XML

Word

Printable

Details

Type: Improvement
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 3.7.8, 3.8.5, 3.9.2
Fix Version/s: 3.11
Component/s: Forum, Web Services
Labels:
- ci
- release_notes
- triaged

Affected Branches:
MOODLE_37_STABLE, MOODLE_38_STABLE, MOODLE_39_STABLE
Fixed Branches:
MOODLE_311_STABLE
Pull from Repository:
git://github.com/paulholden/moodle.git
Pull 3.11 Branch:
~~MDL-70037~~-311
Pull 3.11 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_311_STABLE...paulholden:MDL-70037-311
Pull Master Branch:
~~MDL-70037~~
Pull Master Diff URL:
https://github.com/moodle/moodle/compare/master...paulholden:MDL-70037

Testing Instructions:

Hide

Login as admin
Create a new course and enrol student
Visit the Announcements forum
Press Add a new topic
Enter Subject & Message and press Post to forum
Add a reply to the new discussion
Note the discussion ID in your browser URL: ?d=<ID>
Create a Token for the student user:
- Click on Site administration ► Plugins ► Web services ► Manage tokens
Enable web services

Execute the mod_forum_get_discussion_posts external method simulating a WS client with the student user, substituting your URL, the <ID> value as appropriate and <WSTOKEN> for student user, e.g.:

$ curl -s 'http://localhost/m/stable_master/webservice/rest/server.php?moodlewsrestformat=json' --data 'wsfunction=mod_forum_get_discussion_posts&discussionid=<ID>&wstoken=<WSTOKEN>' | python -m json.tool

Confirm each returned post structure in the discussion contains a timemodified property

Show

Login as admin Create a new course and enrol student Visit the Announcements forum Press Add a new topic Enter Subject & Message and press Post to forum Add a reply to the new discussion Note the discussion ID in your browser URL: ?d=<ID> Create a Token for the student user: Click on Site administration ► Plugins ► Web services ► Manage tokens Enable web services Execute the mod_forum_get_discussion_posts external method simulating a WS client with the student user, substituting your URL, the <ID> value as appropriate and <WSTOKEN> for student user, e.g.: $ curl -s 'http://localhost/m/stable_master/webservice/rest/server.php?moodlewsrestformat=json' --data 'wsfunction=mod_forum_get_discussion_posts&discussionid=<ID>&wstoken=<WSTOKEN>' | python -m json.tool Confirm each returned post structure in the discussion contains a timemodified property

Description

The old function `mod_forum_get_forum_discussion_posts` does return the attribute `modified` for every post (See here https://github.com/moodle/moodle/blob/149fdcf075fdf816b9e83f59e02a5ef20fa998fe/mod/forum/externallib.php#L468). But the new function `mod_forum_get_discussion_posts` does not (see here https://github.com/moodle/moodle/blob/a411b499b98afc9901c24a9466c7e322946a04aa/mod/forum/classes/local/exporters/post.php#L92).

Is that intended? Why is there the possibility to sort by last modified, but you don't get the attribute back? How else can you get this attribute?

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

MDL-70037.jpg
62 kB
02/Dec/20 10:21 AM

Activity

People

Assignee:: Paul Holden

Reporter:: C0D3D3V

Peer reviewer:: Peter Dias

Integrator:: Sara Arjona (@sarjona)

Tester:: Anna Carissa Sadia

Participants:: Anna Carissa Sadia, C0D3D3V, Carlos Escobedo, CiBoT, Paul Holden, Peter Dias, Sara Arjona (@sarjona)

Component watchers:: Adrian Greeve, Ilya Tregubov, Kevin Percy, Mathew May, Mihail Geshoski, Shamim Rezaie, Juan Leyva, David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo

Votes:: 0 Vote for this issue

Watchers:: 6 Start watching this issue

Dates

Created:: 27/Oct/20 11:59 PM

Updated:: 11/May/21 3:26 PM

Resolved:: 04/Dec/20 9:25 AM

Fix Release Date:: 17/May/21

Time Tracking

Estimated:

Remaining:

Logged:

1h 15m