Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-70052

Licenses conditional cannot be reached in filemanager.js

    XMLWordPrintable

Details

    • Bug
    • Status: Open
    • Minor
    • Resolution: Unresolved
    • 3.9.3, 3.10
    • None
    • Filepicker
    • MOODLE_310_STABLE, MOODLE_39_STABLE

    Description

      Noticed this when landing the fix in MDL-70041.

      Basically, the changes made to lib/form/filemanager.js in MDL-45184 (specifically, this code) seem to have no impact, as we'll always have a file node when populating licenses within the file manager. As far as I can tell, that only happens when you click a file in the manager.

      For posterity, we're talking about the else if in this code from within populateLicensesSelect.

      if (filenode) {
          // File has a license already, use it.
          selectedlicense = filenode.license;
      } else if (this.filepicker_options.rememberuserlicensepref) {
          selectedlicense = this.get_preference('recentlicense');
      } 

      Attachments

        Issue Links

          Activity

            People

              Unassigned Unassigned
              jaked Jake Dallimore
              David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated: