Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-70067

Template in theme/classic using CSS class that was removed in Bootstrap 4

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.9.2, 3.10, 3.11, 4.0
    • Fix Version/s: 3.9.4, 3.10.1
    • Component/s: Themes
    • Testing Instructions:
      Hide

      Before Patch:

      1. Set the site theme to 'Classic'
      2. Navigate to your user preferences, then click 'Edit Profile'
      3. On the edit profile page scroll down to the 'Description' field and click on the 'Manage files' button in the Atto editor
      4. See that the 'File manager' only takes up half of the popup window width

      After Patch:

      1. Set the site theme to 'Classic'
      2. Navigate to your user preferences, then click 'Edit Profile'
      3. On the edit profile page scroll down to the 'Description' field and click on the 'Manage files' button in the Atto editor
      4. See that the 'File manager' takes up all of the popup window width
      Show
      Before Patch: Set the site theme to 'Classic' Navigate to your user preferences, then click 'Edit Profile' On the edit profile page scroll down to the 'Description' field and click on the 'Manage files' button in the Atto editor See that the 'File manager' only takes up half of the popup window width After Patch: Set the site theme to 'Classic' Navigate to your user preferences, then click 'Edit Profile' On the edit profile page scroll down to the 'Description' field and click on the 'Manage files' button in the Atto editor See that the 'File manager' takes up all of the popup window width
    • Affected Branches:
      MOODLE_310_STABLE, MOODLE_311_STABLE, MOODLE_39_STABLE, MOODLE_400_STABLE
    • Fixed Branches:
      MOODLE_310_STABLE, MOODLE_39_STABLE
    • Pull from Repository:
    • Pull 3.9 Branch:
      MDL-70067-39_theme_classic
    • Pull 3.9 Diff URL:
    • Pull 3.10 Branch:
      MDL-70067-310_theme_classic
    • Pull 3.10 Diff URL:
    • Pull Master Branch:
      MDL-70067-master_theme_classic
    • Pull Master Diff URL:

      Description

      Moodle 3.9 uses Bootstrap 4 and the file `theme/classic/templates/contentonly.mustache` is using the class `col-xs-12` which was removed in Bootstrap 4.

      This causes a visual bug on pages where that template is used, the one that I noticed it on was the manage files plugin for the atto editor.

      I've attached a screenshot of the problem.

       

      The file still uses .col-xs-12 in the master branch, so presumably this will affect 3.9 -> 4/master

        Attachments

        1. MDL-70067 310 after.png
          MDL-70067 310 after.png
          26 kB
        2. MDL-70067 310 before.png
          MDL-70067 310 before.png
          25 kB
        3. MDL-70067 39 after.png
          MDL-70067 39 after.png
          32 kB
        4. MDL-70067 master after.png
          MDL-70067 master after.png
          26 kB
        5. MDL-70067 master before.png
          MDL-70067 master before.png
          25 kB
        6. MDL-70076 39 before.png
          MDL-70076 39 before.png
          36 kB
        7. Screenshot from 2020-10-30 11-34-38.png
          Screenshot from 2020-10-30 11-34-38.png
          62 kB

          Issue Links

          is a regression caused by

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-66999 Misuse of @extend in SCSS

          • Minor - Minor loss of function where workaround is possible
          • Closed
          will help resolve

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-70003 Analytics prediction page column headings don't align

          • Minor - Minor loss of function where workaround is possible
          • Closed

            Activity

              People

              Assignee:
              alexmorris Alexander Morris
              Reporter:
              alexmorris Alexander Morris
              Integrator:
              Andrew Nicols
              Tester:
              Simey Lameze
              Participants:
              Component watchers:
              Bas Brands
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                18/Jan/21

                  Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 1 hour, 51 minutes
                  1h 51m