Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-70070

Some data providers incorrectly named

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Open
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: 3.8.5, 3.9.3
    • Fix Version/s: None
    • Component/s: Unit tests
    • Labels:
      None
    • Affected Branches:
      MOODLE_38_STABLE, MOODLE_39_STABLE

      Description

      Some data providers have been named with the test_ prefix, which means that they will actually be treated as unit tests and executed.

      2006 sm:master> git grep '@dataProvider test_'
      admin/tool/log/store/database/tests/store_test.php:     * @dataProvider test_log_writing_provider
      admin/tool/log/store/standard/tests/store_test.php:     * @dataProvider test_log_writing_provider
      admin/tool/log/store/standard/tests/store_test.php:     * @dataProvider test_decode_other_provider
      admin/tool/log/store/standard/tests/store_test.php:     * @dataProvider test_log_writing_provider
      availability/condition/completion/tests/condition_test.php:     * @dataProvider test_previous_activity_data
      availability/condition/completion/tests/condition_test.php:     * @dataProvider test_section_previous_activity_data
      badges/tests/badgeslib_test.php:     * @dataProvider test_badges_save_external_backpack_provider
      badges/tests/badgeslib_test.php:     * @dataProvider test_badges_create_site_backpack_provider
      badges/tests/badgeslib_test.php:     * @dataProvider test_badges_get_site_primary_backpack_provider
      calendar/tests/std_proxy_test.php:     * @dataProvider test_proxy_testcases()
      calendar/tests/std_proxy_test.php:     * @dataProvider test_proxy_testcases()
      calendar/tests/std_proxy_test.php:     * @dataProvider test_get_set_testcases()
      calendar/tests/std_proxy_test.php:     * @dataProvider test_get_set_testcases()
      filter/mathjaxloader/tests/filter_test.php:     * @dataProvider test_map_language_code_expected_mappings
      filter/mathjaxloader/tests/filtermath_test.php:     * @dataProvider test_math_filtering_inputs
      h5p/tests/framework_test.php:     * @dataProvider test_isPatchedLibrary_provider
      h5p/tests/framework_test.php:     * @dataProvider test_loadLibrarySemantics_provider
      h5p/tests/framework_test.php:     * @dataProvider test_libraryHasUpgrade_provider
      h5p/tests/generator_test.php:     * @dataProvider test_generate_h5p_data_files_creation_provider
      h5p/tests/generator_test.php:     * @dataProvider test_create_h5p_record_provider
      h5p/tests/generator_test.php:     * @dataProvider test_create_contents_libraries_record_provider
      h5p/tests/generator_test.php:     * @dataProvider test_create_library_dependency_record_provider
      h5p/tests/generator_test.php:     * @dataProvider test_create_content_file_provider
      lib/ddl/tests/ddl_test.php:     * @dataProvider test_get_enc_quoted_provider
      lib/ddl/tests/ddl_test.php:     * @dataProvider test_sql_generator_get_rename_field_sql_provider
      lib/tests/mustache_template_source_loader_test.php:     * @dataProvider test_load_test_cases()
      lib/tests/mustache_template_source_loader_test.php:     * @dataProvider test_load_with_dependencies_test_cases()
      lib/tests/mustache_template_source_loader_test.php:     * @dataProvider test_scan_template_source_for_dependencies_test_cases()
      lib/tests/plugininfo/base_test.php:     * @dataProvider test_load_disk_version_branch_supports_provider
      lib/tests/task_manager_test.php:     * @dataProvider test_ensure_adhoc_task_qos_provider
      message/tests/api_test.php:     * @dataProvider test_get_conversation_counts_test_cases()
      message/tests/api_test.php:     * @dataProvider test_get_conversation_counts_test_cases()
      message/tests/externallib_test.php:     * @dataProvider test_get_conversation_counts_test_cases()
      message/tests/externallib_test.php:     * @dataProvider test_get_conversation_counts_test_cases()
      mod/assign/tests/locallib_test.php:     * @dataProvider test_new_submission_empty_testcases
      mod/forum/tests/entities_discussion_test.php:     * @dataProvider test_diplay_period_options_provider
      mod/lesson/tests/locallib_test.php:     * @dataProvider test_get_last_attempt_dataprovider
      

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              Unassigned Unassigned
              Reporter:
              dobedobedoh Andrew Lyons
              Participants:
              Component watchers:
              Andrew Lyons, Dongsheng Cai, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Dates

                Created:
                Updated: