[MDL-70093] PDF dataformat export is misformatted when a cell height is greater than a page height - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 3.9.2, 3.10.1, 3.11, 4.0
Fix Version/s: 3.9.3
Component/s: Libraries
Labels:
- CatalystIT
- ci
- partner
- release_notes
- triaged

Affected Branches:
MOODLE_310_STABLE, MOODLE_311_STABLE, MOODLE_39_STABLE, MOODLE_400_STABLE
Fixed Branches:
MOODLE_39_STABLE
Pull from Repository:
https://github.com/golenkovm/moodle
Pull 3.9 Branch:
MOODLE_39_~~MDL-70093~~
Pull 3.9 Diff URL:
https://github.com/moodle/moodle/compare/3b0d958065e28...golenkovm:MOODLE_39_MDL-70093
Pull Master Branch:
~~MDL-70093~~-master
Pull Master Diff URL:
https://github.com/moodle/moodle/compare/58ba94a72909...golenkovm:MDL-70093-master
Testing Instructions:
Hide

Login as an admin.

Create a course.

Add a Forum activity.

Add a few posts with various text length.

Select Export from the Actions menu.

Select Portable document format (PDF) in the Format dropdown.

Press Export.

Confirm, that rows in the PDF file have expected height.

Confirm, that cells' text not overlapping.
Show
Login as an admin. Create a course. Add a Forum activity. Add a few posts with various text length. Select Export from the Actions menu. Select Portable document format (PDF) in the Format dropdown. Press Export. Confirm , that rows in the PDF file have expected height. Confirm , that cells' text not overlapping.

Description

When writing a row PDF dataformat calculates the height here:

https://github.com/moodle/moodle/blob/58ba94a7290940391d1581e591a64fc7e6bb410a/dataformat/pdf/classes/writer.php#L140

It fails when some cell is big enough to go to the next page, as `$pdf2->getY()` returns Y for the current (read `last`) page, but not the cell height.

Screenshot:

There are not many places in the moodle core that use pdf dataformat, so in order to provide this screenshot I put

return "The user with id '$this->userid' viewed the log report for the course with id '$this->courseid'. Lorem ipsum dolor sit amet, vim ei impetus referrentur definitiones, duo ei quem repudiare dissentiunt. Duo ad choro volutpat quaerendum, erat posse alienum per ne. Nulla ceteros definitionem ne has, an ubique voluptatibus eum. Sea ei simul soluta signiferumque, has no illud atqui oportere. Saperet detraxit mnesarchum eos eu. Ea tempor corpora epicurei eam, ea modo sint reprehendunt sea, usu ex dicam impetus.";

here: https://github.com/moodle/moodle/blob/58ba94a7290940391d1581e591a64fc7e6bb410a/report/log/classes/event/report_viewed.php#L73

Update: This can be easily replicated using Forum export (see testing instruction).

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

MDL-70093.jpg
145 kB
02/Nov/20 11:32 AM
pdf_page_break_overlap.png
57 kB
03/Nov/20 1:34 PM
pdf not overlapping.png
84 kB
02/Nov/20 4:29 PM
Screenshot_1.jpg
69 kB
04/Nov/20 12:15 PM
Screenshot_2.jpg
42 kB
04/Nov/20 12:15 PM

Issue Links

Discovered while testing

MDLQA-15380 CLONE - A teacher can export forum posts

Passed

is a regression caused by

MDL-67547 Render HTML in PDF dataformat export

Closed

is duplicated by

MDL-70087 Forum export to PDF has overlapping text

Closed

Testing discovered

MDL-70117 PDF dataformat export: content can overflow when page headers are involved

Closed

Activity

People

Assignee:: Misha Golenkov

Reporter:: Misha Golenkov

Peer reviewer:: Simey Lameze

Integrator:: Jake Dallimore

Tester:: Janelle Barcega

Participants:: CiBoT, Jake Dallimore, Janelle Barcega, Misha Golenkov, Simey Lameze

Component watchers:: David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo

Votes:: 0 Vote for this issue

Watchers:: 5 Start watching this issue

Dates

Created:: 02/Nov/20 11:21 AM

Updated:: 02/Nov/22 9:06 PM

Resolved:: 05/Nov/20 7:49 PM

Fix Release Date:: 9/Nov/20

Time Tracking

Estimated:

Remaining:

Logged:

3h 24m