Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-70117

PDF dataformat export: content can overflow when page headers are involved

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      1. Login as an admin.
      2. Create a course.
      3. Add a Forum activity.
      4. Add two posts with this string (it's good to enable HTML view and remove all the tags to make sure the text will have the right length):
      5. another one here. another one here. another one here. another one here. another one here. another one here. another one here. another one here. another one here. another one here.
        

      1. Select Export from the Actions menu.
      2. Select Portable document format (PDF) in the Format dropdown.
      3. Press Export.
      4. Confirm, that rows in the PDF file have expected height.
      5. Confirm, that cells' text not overlapping.
      Show
      Login as an admin. Create a course. Add a Forum activity. Add two posts with this string (it's good to enable HTML view and remove all the tags to make sure the text will have the right length): another one here. another one here. another one here. another one here. another one here. another one here. another one here. another one here. another one here. another one here. Select Export from the Actions menu. Select Portable document format (PDF) in the Format dropdown. Press Export. Confirm , that rows in the PDF file have expected height. Confirm , that cells' text not overlapping.
    • Affected Branches:
      MOODLE_310_STABLE, MOODLE_39_STABLE
    • Fixed Branches:
      MOODLE_310_STABLE, MOODLE_39_STABLE
    • Pull from Repository:
    • Pull 3.9 Branch:
      MOODLE_39_MDL-70117
    • Pull 3.10 Branch:
      MOODLE_310_MDL-70117
    • Pull Master Branch:
      master-MDL-70117

      Description

      As originally reported on MDL-70093:

      When a cell is very close to a page long and displayed on a page on which a new page header is generated (such as any page following a very long cell), it results in rowheight problems and visible overlap yet again. I expect that some combination of the header and page break space (see screen shot where I've highlighted this) is at play here.

       

      The interesting thing is that this 'page break' space/margin (or whatever it's called) is only applied the first time the content crosses a page boundary. If the cell spans many many pages, you'll notice only the end of the first page gets this margin.

      I've attached a screenshot which demonstrates this problem. It's essentially the same with or without the patch (the erroneous heading is removed with the patch, however) and, I suspect is another issue entirely. Thought it worth reporting anyway.
      To replicate this in a new forum, just follow the steps below:
      1. Create a new forum
      2. Create a post with exactly this content:

       

      another one here. another one here. another one here. another one here. another one here. another one here. another one here. another one here. another one here. another one here.

       

      3. Create a reply to the above post, using the exact same content.
      4. Export the forum as a pdf and note the overlap.

        Attachments

        1. extended lenth.jpg
          extended lenth.jpg
          58 kB
        2. MDL-70117-310 discussion.pdf
          114 kB
        3. MDL-70117-39 discussion.pdf
          114 kB
        4. MDL-70117-master discussion.pdf
          114 kB
        5. pdf_page_break_overlap.png
          pdf_page_break_overlap.png
          57 kB

          Issue Links

            Activity

              People

              Assignee:
              mikhailgolenkov Mikhail Golenkov
              Reporter:
              jaked Jake Dallimore
              Peer reviewer:
              Simey Lameze
              Integrator:
              Adrian Greeve
              Tester:
              Carlos Escobedo
              Participants:
              Component watchers:
              Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona)
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                18/Jan/21

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 2 hours, 35 minutes
                  2h 35m