Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-70120

Fix expires length typo in mod assign edit feedback stamps plugin files

    XMLWordPrintable

Details

    • MOODLE_310_STABLE
    • MOODLE_310_STABLE
    • MDL-70120-assign-stamp-expires
    • Hide

      Requirements

      1. Ghostscript (pathtogs)
      2. A course with a student

      Testing

      1. Login as a teacher
      2. Create an assignment
      3. Open your browser developer tools and ensure that the "Network" tab is collecting data
      4. Press the "Grade submissions" button
      5. Using the EditPDF tools add some stamps to the (empty) page
      6. Inspect the stamps on the page using your browser tools. The URL should look similar to: 

        /pluginfile.php/1/assignfeedback_editpdf/systemstamps/8c96a486d5801e0f4ab8c411f561f1c687e1f865/cross.png

      7. Open the network tab and filter by systemstamps to find the stamps
      8. Select one of the stamps and look at the Response headers
        1. Confirm that the Expires section is in the far future
        2. Confirm that the max-age is a large number (like 7776000)
        3. Confirm that an "etag" header is set
        4. *Confirm that the Content-Disposition includes "inline"
      Show
      Requirements Ghostscript (pathtogs) A course with a student Testing Login as a teacher Create an assignment Open your browser developer tools and ensure that the "Network" tab is collecting data Press the "Grade submissions" button Using the EditPDF tools add some stamps to the (empty) page Inspect the stamps on the page using your browser tools. The URL should look similar to: /pluginfile.php/1/assignfeedback_editpdf/systemstamps/8c96a486d5801e0f4ab8c411f561f1c687e1f865/cross.png Open the network tab and filter by systemstamps to find the stamps Select one of the stamps and look at the Response headers Confirm that the Expires section is in the far future Confirm that the max-age is a large number (like 7776000 ) Confirm that an " etag " header is set *Confirm that the Content-Disposition includes " inline "

    Description

      Missed header in MDL-68665. The stamp files should have far future expires

      Attachments

        Issue Links

          Discovered while testing

          Improvement - An enhancement to an existing Moodle feature. MDL-68665 Improve cacheability of assignfeedback_editpdf/stamps

          • Minor - Minor loss of function where workaround is possible
          • Closed

          Activity

            People

              brendanheywood Brendan Heywood
              brendanheywood Brendan Heywood
              Jamie Stamp Jamie Stamp
              Andrew Lyons Andrew Lyons
              Anna Carissa Sadia Anna Carissa Sadia
              Adrian Greeve, Ilya Tregubov, Kevin Percy, Mathew May, Mihail Geshoski, Shamim Rezaie
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                9/Nov/20

                Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 3 hours, 20 minutes
                  3h 20m