Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-70131

CLI no longer recognises parameter starting with no-

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.10, 4.0
    • Fix Version/s: 3.10
    • Component/s: Other
    • Labels:
    • Affected Branches:
      MOODLE_310_STABLE, MOODLE_400_STABLE
    • Fixed Branches:
      MOODLE_310_STABLE
    • Pull 3.10 Branch:
      MDL-70131-310
    • Testing Instructions:
      Hide
      1. Run: php admin/cli/cfg.php --component=enrol_self --name=version
      2. Make sure the version is printed and the command prompt is on the next line
      3. Run: php admin/cli/cfg.php --component=enrol_self --name=version --no-eol
      4. Make sure the version is printed and the command prompt is on the same line (--no-eol means "no end of line character")
      Show
      Run: php admin/cli/cfg.php --component=enrol_self --name=version Make sure the version is printed and the command prompt is on the next line Run: php admin/cli/cfg.php --component=enrol_self --name=version --no-eol Make sure the version is printed and the command prompt is on the same line (--no-eol means "no end of line character")

      Description

      We have a CLI script that had parameter "--no-tenant" (without value)
      after https://github.com/moodle/moodle/commit/b0e096d870e747208259f7b5ace74bfc1d1367db the function cli_get_params() ignores it

      I'm not sure why was this change needed

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              marina Marina Glancy
              Reporter:
              marina Marina Glancy
              Peer reviewer:
              Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
              Integrator:
              Andrew Lyons Andrew Lyons
              Tester:
              Janelle Barcega Janelle Barcega
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan
              Votes:
              1 Vote for this issue
              Watchers:
              6 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                9/Nov/20

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 2 hours, 5 minutes
                  2h 5m