[MDL-70242] OAuth2 login page does not set context and page url causing debugging messages - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 3.9.3, 3.10
Fix Version/s: 3.9.4, 3.10.1
Component/s: Authentication
Labels:
- ci

Testing Instructions:
Hide

I think it's an overkill to ask tester to try to reproduce the whole problem (setup oAuth2, write event observer, etc), so here is a small workaround.

1. Modify the file auth/oauth2/login.php and insert a line

echo format_string($SITE->fullname);exit;

before require_sesskey();

2. Open this page in the browser ( http://sitename/auth/oauth2/login.php?id=1 ) and make sure that the site name is displayed and there are no debugging messages
Show
I think it's an overkill to ask tester to try to reproduce the whole problem (setup oAuth2, write event observer, etc), so here is a small workaround. 1. Modify the file auth/oauth2/login.php and insert a line echo format_string($SITE->fullname);exit; before require_sesskey(); 2. Open this page in the browser ( http://sitename/auth/oauth2/login.php?id=1 ) and make sure that the site name is displayed and there are no debugging messages
Affected Branches:
MOODLE_310_STABLE, MOODLE_39_STABLE
Fixed Branches:
MOODLE_310_STABLE, MOODLE_39_STABLE
Pull from Repository:
git://github.com/marinaglancy/moodle.git
Pull 3.9 Branch:
~~MDL-70242~~-39
Pull 3.9 Diff URL:
https://github.com/marinaglancy/moodle/compare/ff2b655928...MDL-70242-39
Pull 3.10 Branch:
~~MDL-70242~~-310
Pull 3.10 Diff URL:
https://github.com/marinaglancy/moodle/compare/f86b5e3545...MDL-70242-310
Pull Master Branch:
~~MDL-70242~~-master
Pull Master Diff URL:
https://github.com/marinaglancy/moodle/compare/6ef4e66f03...MDL-70242-master

Description

Create an event listener to the user_created event that sends an email using email_to_user() function
Set up oAuth2 login
Login as a new user
You will see debugging messages that the page context is not set, etc.

email_to_user() expects the page context and url to be set but the auth/oauth2/login.php page does not set them. Normally it immediately redirects and it is not important, however the event observers may experience problems

Attachments

Options
- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

Attachments

image-2020-11-26-11-39-08-296.png
46 kB
26/Nov/20 11:39 AM

Activity

People

Assignee:: Marina Glancy

Reporter:: Marina Glancy

Peer reviewer:: Ruslan Kabalin

Integrator:: Andrew Lyons

Tester:: Janelle Barcega

Participants:: Andrew Lyons, CiBoT, Janelle Barcega, Marina Glancy, Ruslan Kabalin

Component watchers:: Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan

Votes:: 0 Vote for this issue

Watchers:: 5 Start watching this issue

Dates

Created:: 17/Nov/20 11:43 PM

Updated:: 27/Nov/20 4:01 PM

Resolved:: 27/Nov/20 4:01 PM

Fix Release Date:: 18/Jan/21

Time Tracking

Estimated:

Not Specified

Remaining:

Logged:

1h 56m