[MDL-70245] Static variable $cache in grade_get_setting causes unit test failures - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 3.7.9, 3.8.6, 3.9.3, 3.10
Fix Version/s: 3.9.4, 3.10.1
Component/s: Gradebook, Unit tests
Labels:
- CI
- CatalystIT
- Partner

Affected Branches:
MOODLE_310_STABLE, MOODLE_37_STABLE, MOODLE_38_STABLE, MOODLE_39_STABLE
Fixed Branches:
MOODLE_310_STABLE, MOODLE_39_STABLE
Pull from Repository:
https://github.com/TomoTsuyuki/moodle
Pull 3.9 Branch:
~~MDL-70245~~-MOODLE_39_STABLE
Pull 3.9 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_39_STABLE...TomoTsuyuki:MDL-70245-MOODLE_39_STABLE
Pull Master Branch:
~~MDL-70245~~-master
Pull Master Diff URL:
https://github.com/moodle/moodle/compare/master...TomoTsuyuki:MDL-70245-master
Testing Instructions:
Hide

Run Unit Tests

Replicate the issue by a failing unit test that should not fail
Apply 0001-~~MDL-70245~~-test-patch.patch (Please find the attached for this)
git am 0001-~~MDL-70245~~-test-patch.patch

Run vendor/bin/phpunit lib/tests/upgradelib_test.php
Test failed
core_upgradelib_testcase::test_upgrade_update_category_grademax_regrade_final_grades
Failed asserting that '10.00000' matches expected 20.

Apply the solution in this tracker. There could be merge conflict since we included the same unit test in the solution

Run same test vendor/bin/phpunit lib/tests/upgradelib_test.php

Expected:

The failing unit test passed
Show
Run Unit Tests Replicate the issue by a failing unit test that should not fail Apply 0001- MDL-70245 -test-patch.patch (Please find the attached for this) git am 0001- MDL-70245 -test-patch.patch Run vendor/bin/phpunit lib/tests/upgradelib_test.php Test failed core_upgradelib_testcase::test_upgrade_update_category_grademax_regrade_final_grades Failed asserting that '10.00000' matches expected 20. Apply the solution in this tracker. There could be merge conflict since we included the same unit test in the solution Run same test vendor/bin/phpunit lib/tests/upgradelib_test.php Expected: The failing unit test passed

Description

When the unit test tries to validate "finalgrade" with different set of grade max, then it will fail after "test_upgrade_calculated_grade_items_freeze" function in core_testsuite because the static $cache variable does not reset and the "minmaxtouse" collides with previous unit tests.

Steps to reproduce:

Write unit test (attached in MDL-70245-patch.txt) that implement to validate "finalgrade" with different set of grademax (for course category and grade item) after the function "test_upgrade_calculated_grade_items_freeze" .
Run vendor/bin/phpunit --testsuite=core_testsuite

Expected:

Unit tests pass

Actual:

Unit tests fail with unexpected "finalgrade" getting returned (because it is using the previous "minmaxtouse" which is set in the function "test_upgrade_calculated_grade_items_freeze")

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

0001-MDL-70245-test-patch.patch
3 kB
22/Dec/20 9:00 AM
MDL-70245-patch.txt
5 kB
14/Dec/20 1:59 PM

Activity

People

Assignee:: Tomo Tsuyuki

Reporter:: Anupama Dharmajan

Peer reviewer:: John Yao

Integrator:: Eloy Lafuente (stronk7)

Tester:: Eloy Lafuente (stronk7)

Participants:: Anupama Dharmajan, CiBoT, Dmitrii Metelkin, Eloy Lafuente (stronk7), John Yao, Tomo Tsuyuki

Component watchers:: Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Sujith Haridasan, Andrew Lyons, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze

Votes:: 0 Vote for this issue

Watchers:: 5 Start watching this issue

Dates

Created:: 18/Nov/20 7:55 AM

Updated:: 08/Jan/21 5:12 PM

Resolved:: 08/Jan/21 1:44 PM

Fix Release Date:: 18/Jan/21

Time Tracking

Estimated:

Remaining:

Logged:

45m