Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-70266

Quiz override screens should show user identity fields

    XMLWordPrintable

Details

    • New Feature
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 3.8.6, 3.9.3, 3.10
    • 3.11
    • Quiz
    • MOODLE_310_STABLE, MOODLE_38_STABLE, MOODLE_39_STABLE
    • MOODLE_311_STABLE
    • MDL-70266_311
    • Hide

      I think the Behat coverage is pretty good, but probably worth having some human eyeballs other than mine checking it all out.

      Set up

      1. Edit the (editing) teacher role (either at system-level, or in the course you will use) to remove the moodle/site:viewuseridentity capability.
      2. Check the setting Admin -> Users -> Permissions -> User policies -> Show user identity setting. Make sure that at least one option is selected there.
      3. Verify that some students are enrolled in the course.
      4. Create a quiz.

      Testing as admin (can see user identity)

      1. Log in as admin.
      2. Create a quiz.
      3. Choose Settings -> User overrides.
      4. Add a new overrides.
      5. Verify that when you select which user you want, all the user identity information for that user is shown in brackets after the name.
      6. Save the override.
      7. Verify that, back on the list of overrides, the table has a column for each identity field afer the name.
      8. Delete the override you created.
      9. Verify that the 'Are you sure' message includes all the user identity information for that user is shown in brackets after the name.

      Testing as teacher (cannot see user identity)

      1. Log in as admin.
      2. Create a quiz.
      3. Choose Settings -> User overrides.
      4. Add a new overrides.
      5. Verify that when you select which user you want, you can only see the student names.
      6. Save the override.
      7. Verify that, back on the list of overrides, the table only has a name column to identify the students.
      8. Delete the override you created.
      9. Verify that the 'Are you sure' message only includes the student's name.
      Show
      I think the Behat coverage is pretty good, but probably worth having some human eyeballs other than mine checking it all out. Set up Edit the (editing) teacher role (either at system-level, or in the course you will use) to remove the moodle/site:viewuseridentity capability. Check the setting Admin -> Users -> Permissions -> User policies -> Show user identity setting. Make sure that at least one option is selected there. Verify that some students are enrolled in the course. Create a quiz. Testing as admin (can see user identity) Log in as admin. Create a quiz. Choose Settings -> User overrides. Add a new overrides. Verify that when you select which user you want, all the user identity information for that user is shown in brackets after the name. Save the override. Verify that, back on the list of overrides, the table has a column for each identity field afer the name. Delete the override you created. Verify that the 'Are you sure' message includes all the user identity information for that user is shown in brackets after the name. Testing as teacher (cannot see user identity) Log in as admin. Create a quiz. Choose Settings -> User overrides. Add a new overrides. Verify that when you select which user you want, you can only see the student names. Save the override. Verify that, back on the list of overrides, the table only has a name column to identify the students. Delete the override you created. Verify that the 'Are you sure' message only includes the student's name.

    Description

      The screens where you create, view, edit and delete settings overrdies for quizzes just show the username. This is not very helpful if you have several people called "Martin Dougiamas" in your course.

      These screens should obey $CFG->showuseridentity.

      Specifically:

      1. mod/quiz/overrides.php&mode=user should include all the identity fields in the table.
      2. overrideedit.php?action=adduser and overrideedit.php?id=123 should show the identity fields in the select user autocomplete.
      3. overridedelete.php should show the identity fields when confirming which override to delete - if you are deleting a user override.

      Attachments

        1. add override.png
          add override.png
          12 kB
        2. delete override.png
          delete override.png
          7 kB
        3. override list.png
          override list.png
          15 kB
        4. Screenshot_1.jpg
          Screenshot_1.jpg
          66 kB
        5. Screenshot_2.jpg
          Screenshot_2.jpg
          62 kB

        Issue Links

          Activity

            People

              timhunt Tim Hunt
              timhunt Tim Hunt
              Mahmoud Kassaei Mahmoud Kassaei
              Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
              Janelle Barcega Janelle Barcega
              Tim Hunt, Andrew Lyons, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, Stevani Andolo
              Votes:
              1 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                17/May/21

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 1 hour, 55 minutes
                  1h 55m