Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-70276

Add support for github actions to moodle.git

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Notes:

      • dev is required for testing this (git access, integration.git as remote and github clone of moodle.git)
      • this must be done for all branches.

      Instructions:

      1. Ensure that you've github actions enabled for your moodle clone:
        1. Go to https://github.com/YOURUSER/moodle/settings/actions
        2. Verify that "Allow all actions" is ticked.
      2. Pull the corresponding branch from integration.git to local branch with easy to remember name (actions-master, actions-311...).
      3. Push all those branches to github.
      4. Go to your https://github.com/YOURUSER/moodle/actions URL, there should be a workflow for each of the pushed branches.
      5. Verify they run grunt and a couple of phpunit jobs.
      6. Verify they end ok / green / passing
      7. Don't forget to remove the branches from your repos after the test.
      8. Also, verify that the badges in this issue (this is the only issue currently showing them) are linking to a workflow run, exactly to the last one for a branch. To do this you can:
        1. go to https://github.com/stronk7/moodle/actions
        2. then look/filter for branch:MDL-70276_35 for example.
        3. that will show all the runs performed against the 35 branch of this issue.
        4. Verify that the 1st element in the list, the more recent one, matches the badge URL shown here.
      9. Run locally php .github/workflows/config-template.php and verify that it dies silently and nothing is executed / output.
      10. Run in your browser http://your.moodle.site/path/to/.github/workflows/config-template.php and verify that it dies silently and nothing is executed / output.
      Show
      Notes: dev is required for testing this (git access, integration.git as remote and github clone of moodle.git) this must be done for all branches. Instructions: Ensure that you've github actions enabled for your moodle clone: Go to https://github.com/YOURUSER/moodle/settings/actions Verify that "Allow all actions" is ticked. Pull the corresponding branch from integration.git to local branch with easy to remember name (actions-master, actions-311...). Push all those branches to github. Go to your https://github.com/YOURUSER/moodle/actions URL, there should be a workflow for each of the pushed branches. Verify they run grunt and a couple of phpunit jobs. Verify they end ok / green / passing Don't forget to remove the branches from your repos after the test. Also, verify that the badges in this issue (this is the only issue currently showing them) are linking to a workflow run, exactly to the last one for a branch. To do this you can: go to https://github.com/stronk7/moodle/actions then look/filter for branch: MDL-70276 _35 for example. that will show all the runs performed against the 35 branch of this issue. Verify that the 1st element in the list, the more recent one, matches the badge URL shown here. Run locally php .github/workflows/config-template.php and verify that it dies silently and nothing is executed / output. Run in your browser http://your.moodle.site/path/to/.github/workflows/config-template.php and verify that it dies silently and nothing is executed / output.
    • Affected Branches:
      MOODLE_310_STABLE, MOODLE_35_STABLE, MOODLE_38_STABLE, MOODLE_39_STABLE
    • Fixed Branches:
      MOODLE_310_STABLE, MOODLE_35_STABLE, MOODLE_38_STABLE, MOODLE_39_STABLE
    • Pull 3.5 Branch:
    • Pull 3.8 Branch:
    • Pull 3.9 Branch:
    • Pull 3.10 Branch:
      MDL-70276_310
    • Pull 3.11 Branch:
      MDL-70276_311
    • Pull Master Branch:

      Description

      For detailed explanation, read MDL-70265

      Summary: We need alternatives (ideally free for open-source public repositories). And github actions is one of them.

      Goal: Add support for github actions (initially similar to the offered by travis). PHPUnit and Grunt may be a good start. Future expansion, of course is welcome.

      Bonus (mimicking current support for travis) TODO:

      1. Make the tracker show github actions badges.
      2. Make the tracker warn if github actions are disabled (though they are enabled by default).
      3. Make CiBoT to also check for github actions status.

      And, other TODO:

      1. Document this @ dev docs.

        Attachments

        1. ghaction_38.png
          ghaction_38.png
          36 kB
        2. githubactions_all.png
          githubactions_all.png
          60 kB
        3. php.png
          php.png
          22 kB
        4. web.png
          web.png
          21 kB

          Issue Links

            Activity

              People

              Assignee:
              stronk7 Eloy Lafuente (stronk7)
              Reporter:
              stronk7 Eloy Lafuente (stronk7)
              Peer reviewer:
              Ruslan Kabalin
              Integrator:
              Sara Arjona (@sarjona)
              Tester:
              Sara Arjona (@sarjona)
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan, Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              1 Vote for this issue
              Watchers:
              6 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                18/Jan/21

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 1 day, 2 hours, 25 minutes
                  1d 2h 25m