Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-70284

Error in claims returned in LTI Registration Response

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      In this test, we deploy an LTI 1.3 test tool using dynamic registration and verify the response contains the proper claims:

      pre-requisite

      1. LTI Advantage requires your site to be reachable from the internet. If not, Install ngrok to expose your moodle setup externally. Refer here for additional guidelines
      2. Have a course with an instructor.

      Verify claims

      1. As site administrator, navigate to Site Admin > Plugins > Activity Modules > External Tool > Manage Tools
      2. In the box that says tool url enter: https://robotest.theedtech.dev/register
      3. Click the Add LTI Advantage button
      4. The test tool should open with a trace of the communication with Moodle, all should be green (thumbs up).
      5. Verify the Registration Response JSON (Successful Registration section) has:
        1. "application_type": "web"
        2. "claims": [
          "sub",
          "iss",
          "name",
          "family_name",
          "given_name"
          ]
      6. Click the close button - the test app UI should disappear and the list of tools refreshing
      7. Verify the Robotest app has been added and is not yet activated
      8. You can now remove that tool

       

      Show
      In this test, we deploy an LTI 1.3 test tool using dynamic registration and verify the response contains the proper claims: pre-requisite LTI Advantage requires your site to be reachable from the internet. If not, Install ngrok to expose your moodle setup externally. Refer here for additional guidelines Have a course with an instructor. Verify claims As site administrator, navigate to Site Admin > Plugins > Activity Modules > External Tool > Manage Tools In the box that says tool url enter: https://robotest.theedtech.dev/register Click the Add LTI Advantage button The test tool should open with a trace of the communication with Moodle, all should be green (thumbs up). Verify the Registration Response JSON (Successful Registration section) has: "application_type": "web" "claims": [ "sub", "iss", "name", "family_name", "given_name" ] Click the close button - the test app UI should disappear and the list of tools refreshing Verify the Robotest app has been added and is not yet activated You can now remove that tool  
    • Workaround:
      Hide

      The tool should just ignore the claims information returned in the response. Anyway those are informational as they can be changed at any time by the admin.

      Show
      The tool should just ignore the claims information returned in the response. Anyway those are informational as they can be changed at any time by the admin.
    • Affected Branches:
      MOODLE_310_STABLE
    • Fixed Branches:
      MOODLE_310_STABLE
    • Pull from Repository:
    • Pull 3.10 Branch:
      MDL-70284-dynreg-bug-310
    • Pull 3.11 Branch:
      MDL-70284-dynreg-bug-311
    • Pull Master Branch:
      MDL-70284-dynreg-bug

      Description

      After a successful registration, there are some errors in the echo-ed registration sent to back to the client:

      • The application type is not a string but an array
      • The claims always contain the full set even not all were actually set in the tool config

        Attachments

          Activity

            People

            Assignee:
            claudevervoort Claude Vervoort
            Reporter:
            claudevervoort Claude Vervoort
            Peer reviewer:
            Jake Dallimore
            Integrator:
            Víctor Déniz Falcón
            Tester:
            Janelle Barcega
            Participants:
            Component watchers:
            Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              18/Jan/21

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 2 hours, 5 minutes
                2h 5m