Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-70314

Upgrade PHPSpreadsheet to 1.16.0

    XMLWordPrintable

Details

    • MOODLE_311_STABLE, MOODLE_400_STABLE
    • MOODLE_311_STABLE
    • MDL-70314-311
    • Hide

      Testing scenario 1

      1. Login as admin
      2. Go to http://yourmoodleurl/lib/tests/other/spreadsheettestpage.php and generate the Excel sample file.
      3. Review the server error logs to make sure there are no notices there.
      4. Open the Excel sample file in various office suites.
      5. Expected Result: Check the content is displayed as expected (Font colors, headings etc). You can download the ODS file and compare with it or download the Excel file without that patch. Alternatively, you can also compare to the moodletest_withoutpatch.xlsx attached file (which was created without the patch).
        1. NOTE: That you'll notice a change in default font size & font family within the XLSX file and that this is expected

       

      Testing scenario 2

      1. Login as admin.
      2. Create a course with some enrolled students and one graded activity for some of them (at least).
      3. Access to the course.
      4. Go to Grades / Export / Excel spreadsheet
      5. Click over the Download button
      6. Expected Result: Check the file is downloaded and contains one row per user and, at least, the following columns:  "First name", "Surname", "ID number", "Institution", "Department", "Email address", "Course total", "Last downloaded from this course" and one column for each activity.
      Show
      Testing scenario 1 Login as admin Go to  http://yourmoodleurl/lib/tests/other/spreadsheettestpage.php  and generate the Excel sample file. Review the server error logs to make sure there are no notices there. Open the Excel sample file in various office suites. Expected Result: Check the content is displayed as expected (Font colors, headings etc). You can download the ODS file and compare with it or download the Excel file without that patch. Alternatively, you can also compare to the moodletest_withoutpatch.xlsx  attached file (which was created without the patch). NOTE: That you'll notice a change in default font size & font family within the XLSX file and that this is expected   Testing scenario 2 Login as admin. Create a course with some enrolled students and one graded activity for some of them (at least). Access to the course. Go to Grades / Export / Excel spreadsheet Click over the Download button Expected Result: Check the file is downloaded and contains one row per user and, at least, the following columns:  "First name", "Surname", "ID number", "Institution", "Department", "Email address", "Course total", "Last downloaded from this course" and one column for each activity.
    • 3
    • 4.0 holding pattern 10, 4.0 holding pattern 11, 4.0 holding pattern 12, 4.0 Navigation blitz

    Description

      PhpSpreadsheet (/lib/phpspreadsheet/) 1.10.1 --> 1.16.0 : https://github.com/PHPOffice/PhpSpreadsheet/releases 
       

      Attachments

        1. moodletest_withoutpatch.xlsx
          12 kB
        2. Screenshot from 2021-01-22 13-37-17.png
          Screenshot from 2021-01-22 13-37-17.png
          110 kB
        3. Screenshot_1.jpg
          Screenshot_1.jpg
          54 kB
        4. Screenshot_2.jpg
          Screenshot_2.jpg
          37 kB
        5. Screenshot_3.jpg
          Screenshot_3.jpg
          48 kB

        Issue Links

          Activity

            People

              mathewmay Mathew May
              sarjona Sara Arjona (@sarjona)
              Peter Dias Peter Dias
              Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
              Janelle Barcega Janelle Barcega
              David Woloszyn, Huong Nguyen, Jake Dallimore, Michael Hawkins, Stevani Andolo
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                17/May/21

                Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 1 week, 2 hours, 40 minutes
                  1w 2h 40m