Details
-
Bug
-
Status: Closed
-
Minor
-
Resolution: Fixed
-
3.10, 3.11
-
MOODLE_310_STABLE, MOODLE_311_STABLE
-
MOODLE_310_STABLE
-
MDL-70322-311 -
MDL-70322-master -
- Enable 'Global search' in "Site administration > Advanced features > enableglobalsearch".
- Install the attached theme plugin theme_mdl70322.zip
(that overrides "core:a/search" icon with a star icon). - Change default theme to '
MDL-70322' in "Site administration > Appearance > Themes > Theme selector". - Global search icon in the navbar now is shown as a star.
- Check that after clicking the star icon in the navbar, it is still shown as a star.
Enable 'Global search' in "Site administration > Advanced features > enableglobalsearch". Install the attached theme plugin theme_mdl70322.zip (that overrides "core:a/search" icon with a star icon). Change default theme to ' MDL-70322 ' in "Site administration > Appearance > Themes > Theme selector". Global search icon in the navbar now is shown as a star. Check that after clicking the star icon in the navbar, it is still shown as a star.
Description
I detected some inconsistency while working on search input in the Workplace navbar. "inactive" search icon was not getting the icon mapping, but the "active" search was doing the mapping correctly.
Looking at lib/templates/search_input_navbar.mustache i see that these icons are being included in two different ways.
-
{{#pix}} a/search, core {{/pix}}Can be mapped.
-
<i class="icon fa fa-search fa-fw " aria-hidden="true"></i>Cannot be mapped
I suggest using pix a/search, core in both cases to allow mapping and to be consistent.
Attachments
Issue Links
- has been marked as being related by
-
MDL-69454 Use a consistent search input field across all Moodle searches
-
- Closed
-
