Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-70322

Search icon inconsistency in 'search_input_navbar.mustache'

XMLWordPrintable

    • MOODLE_310_STABLE, MOODLE_311_STABLE
    • MOODLE_310_STABLE
    • MDL-70322-master
    • Hide
      1. Enable 'Global search' in "Site administration > Advanced features > enableglobalsearch".
      2. Install the attached theme plugin theme_mdl70322.zip(that overrides "core:a/search" icon with a star icon).
      3. Change default theme to 'MDL-70322' in "Site administration > Appearance > Themes > Theme selector".
      4. Global search icon in the navbar now is shown as a star.
      5. Check that after clicking the star icon in the navbar, it is still shown as a star.
      Show
      Enable 'Global search' in "Site administration > Advanced features > enableglobalsearch". Install the attached theme plugin theme_mdl70322.zip (that overrides "core:a/search" icon with a star icon). Change default theme to ' MDL-70322 ' in "Site administration > Appearance > Themes > Theme selector". Global search icon in the navbar now is shown as a star. Check that after clicking the star icon in the navbar, it is still shown as a star.

      I detected some inconsistency while working on search input in the Workplace navbar. "inactive" search icon was not getting the icon mapping, but the "active" search was doing the mapping correctly.


      Looking at lib/templates/search_input_navbar.mustache i see that these icons are being included in two different ways.

      • {{#pix}} a/search, core {{/pix}}
        

        Can be mapped.

      • <i class="icon fa fa-search fa-fw " aria-hidden="true"></i>
        

        Cannot be mapped

      I suggest using pix a/search, core in both cases to allow mapping and to be consistent.

        1. MDL-70322_screenshot.PNG
          8 kB
          Gladys Basiana
        2. screenshot-1.png
          4 kB
          Mikel Martín Corrales
        3. screenshot-2.png
          5 kB
          Mikel Martín Corrales

            mikelmartíncorrales Mikel Martín Corrales
            mikelmartíncorrales Mikel Martín Corrales
            Bas Brands Bas Brands
            Sara Arjona (@sarjona) Sara Arjona (@sarjona)
            Gladys Basiana Gladys Basiana
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 1 hour, 41 minutes
                1h 41m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.