Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-70322

Search icon inconsistency in 'search_input_navbar.mustache'

    XMLWordPrintable

    Details

      Description

      I detected some inconsistency while working on search input in the Workplace navbar. "inactive" search icon was not getting the icon mapping, but the "active" search was doing the mapping correctly.


      Looking at lib/templates/search_input_navbar.mustache i see that these icons are being included in two different ways.

      • {{#pix}} a/search, core {{/pix}}
        

        Can be mapped.

      • <i class="icon fa fa-search fa-fw " aria-hidden="true"></i>
        

        Cannot be mapped

      I suggest using pix a/search, core in both cases to allow mapping and to be consistent.

        Attachments

        1. MDL-70322_screenshot.PNG
          8 kB
          Gladys Basiana
        2. screenshot-1.png
          4 kB
          Mikel Martín Corrales
        3. screenshot-2.png
          5 kB
          Mikel Martín Corrales

          Issue Links

            Activity

              People

              Assignee:
              mikelmartíncorrales Mikel Martín Corrales
              Reporter:
              mikelmartíncorrales Mikel Martín Corrales
              Peer reviewer:
              Bas Brands
              Integrator:
              Sara Arjona (@sarjona)
              Tester:
              Gladys Basiana
              Participants:
              Component watchers:
              Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona), Bas Brands
              Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                18/Jan/21

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 1 hour, 41 minutes
                  1h 41m