Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-70339

Activity chooser does not honour external tool icons

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      1. Login as an admin
      2. Create a course if you don't have one already.
      3. Go to Site Administration > Plugins > Activity Modules > External tool > Manage tools
      4. Click on the 'configure a tool manually' link
      5. Fill in the form with the following values:
        1. Tool name - Tool1
        2. 'Tool URL' - www.google.com
        3. 'Tool configuration usage' - 'Show in activity chooser
        4. Icon URL - not set
        5. Secure icon URL - not set
      6. Save changes
      7. Create 2 more tools by repeating #4 - #6,  with the following conditions
        1. Tool2 - Only icon URL set
        2. Tool3 - Both icon and secure icon URL set
      8. Go to the course homepage.
      9. Open up the activity chooser and confirm the following:
        1. Tool1 shows the default generic tool icon
        2. Tool2 shows the icon set in the 'icon URL'
        3. Tool3 shows the icon set in the 'secured icon URL'
      Show
      Login as an admin Create a course if you don't have one already. Go to Site Administration > Plugins > Activity Modules > External tool > Manage tools Click on the 'configure a tool manually' link Fill in the form with the following values: Tool name - Tool1 'Tool URL' - www.google.com 'Tool configuration usage' - 'Show in activity chooser Icon URL - not set Secure icon URL - not set Save changes Create 2 more tools by repeating #4 - #6,  with the following conditions Tool2 - Only icon URL set Tool3 - Both icon and secure icon URL set Go to the course homepage. Open up the activity chooser and confirm the following: Tool1 shows the default generic tool icon Tool2 shows the icon set in the 'icon URL' Tool3 shows the icon set in the 'secured icon URL'
    • Affected Branches:
      MOODLE_39_STABLE
    • Fixed Branches:
      MOODLE_310_STABLE, MOODLE_39_STABLE
    • Pull from Repository:
    • Pull 3.9 Branch:
    • Pull 3.10 Branch:
      MDL-70339-310
    • Pull 3.11 Branch:
      MDL-70339-311
    • Pull Master Branch:
      MDL-70339-master
    • Story Points:
      1
    • Sprint:
      4.0 holding pattern 11, 4.0 holding pattern 12

      Description

      I have manually configured a couple LTI tools and assigned the secured icon URL to them.

      The tool list correctly shows the icon and also do the courses when listing the activities but when I open the activity chooser in order to add a new activity the standar puzzle icon appears instead of the provided icon.

      I think this might be a regression because a similar issue was already patched a couple of years ago:  https://tracker.moodle.org/browse/MDL-60196

        Attachments

          Activity

            People

            Assignee:
            peterdias Peter Dias
            Reporter:
            iblanco Igor Blanco
            Peer reviewer:
            Mathew May
            Integrator:
            Andrew Nicols
            Tester:
            Janelle Barcega
            Participants:
            Component watchers:
            Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan
            Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              8/Mar/21

                Time Tracking

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 2 hours, 16 minutes
                2h 16m