Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-70340

WebService mod_workshop_get_assessment_form_definition is filtering text that should not be filtered

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.9.3, 3.10.1, 3.11, 4.0
    • Fix Version/s: 3.9.5, 3.10.2
    • Component/s: Workshop
    • Labels:
    • Testing Instructions:
      Hide
      Prerequisite
      1. Moodle mobile app.
      2. Your Moodle mobile app should be able to connect to your Moodle website. You can either do the following:
        • Ensure that the phone with the mobile app and the web server are on the same network. Or
        • Expose the web server over the internet via ngrok.
      Test
      1. Create a new course
      2. Via Course settings cog -> Filters ensure that the "Display emoticons as images" filter is ON
      3. Enrol a couple users as student (student2 and student1) and one user as teacher
      4. Add a workshop activity
      5. As teacher, move the workshop to the submission phase (doing all the required configuration steps indicated by the activity and using the default values). For the description and submission you can use random text. And same for the assertions in the assessment form.
      6. Accesing to the site as the two students, do a submission (total of 2 submissions, one per student).
      7. As teacher, move the workshop to the assessment phase, allocating the assessment of the submissions: student2 will assess student1 and vice versa.
      8. Now, in Moodle web, accessing as student1 complete the assessment of the student2 submission in the "Comment for Assertion X" fields use the following text: "Emoticons "
      9. Do the same with student2 but completing the assessment for student1 using the same text
      10. Now, using the mobile app, access as teacher to the site, go to the workshop
      11. Open the assessments that student1 did for student2 and confirm that
        • In the comments for the Aspects you see the exact text "Emoticons " and you don't see any HTML or images
      Show
      Prerequisite Moodle mobile app. Your Moodle mobile app should be able to connect to your Moodle website. You can either do the following: Ensure that the phone with the mobile app and the web server are on the same network. Or Expose the web server over the internet via ngrok. Test Create a new course Via Course settings cog -> Filters ensure that the "Display emoticons as images" filter is ON Enrol a couple users as student (student2 and student1) and one user as teacher Add a workshop activity As teacher, move the workshop to the submission phase (doing all the required configuration steps indicated by the activity and using the default values). For the description and submission you can use random text. And same for the assertions in the assessment form. Accesing to the site as the two students, do a submission (total of 2 submissions, one per student). As teacher, move the workshop to the assessment phase, allocating the assessment of the submissions: student2 will assess student1 and vice versa. Now, in Moodle web, accessing as student1 complete the assessment of the student2 submission in the "Comment for Assertion X" fields use the following text: "Emoticons " Do the same with student2 but completing the assessment for student1 using the same text Now, using the mobile app, access as teacher to the site, go to the workshop Open the assessments that student1 did for student2 and confirm that In the comments for the Aspects you see the exact text "Emoticons " and you don't see any HTML or images
    • Affected Branches:
      MOODLE_310_STABLE, MOODLE_311_STABLE, MOODLE_39_STABLE, MOODLE_400_STABLE
    • Fixed Branches:
      MOODLE_310_STABLE, MOODLE_39_STABLE
    • Pull from Repository:
    • Pull 3.9 Branch:
    • Pull 3.10 Branch:
      MDL-70340-310
    • Pull Master Branch:
      MDL-70340-master

      Description

      Peercomment is being filtered (type text) when it shouldnt

      if (strpos($key, 'peercomment_idx') === 0)

      { // Format reviewer comment. list($val, $format) = external_format_text($val, FORMAT_MOODLE, $context->id); }

        Attachments

          Activity

            People

            Assignee:
            jleyva Juan Leyva
            Reporter:
            jleyva Juan Leyva
            Peer reviewer:
            Pau Ferrer
            Integrator:
            Eloy Lafuente (stronk7)
            Tester:
            Anna Carissa Sadia
            Participants:
            Component watchers:
            Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona)
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              8/Mar/21

                Time Tracking

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 3 hours, 20 minutes
                3h 20m