Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-70352

Modal forms stay on the screen if you have multiple modals on one page

XMLWordPrintable

    • MOODLE_39_STABLE
    • MOODLE_310_STABLE, MOODLE_39_STABLE
    • MDL-70352-master
    • Hide
      1. Install the helper plugin https://github.com/dmitriim/moodle-local_helper to local/helper:  

        git clone https://github.com/dmitriim/moodle-local_helper.git local/helper

      2. Navigate to local/helper/index.php
      3. Open the links in that page ("Moodle Wiki example", "On click example 1" and "On click example 2"), and close these modal forms several times using ESC key on keyboard, Cancel button and close link.
      4. Confirm that all modal windows work without issues and you can close and open them as many times as you wish. 
      Show
      Install the helper plugin https://github.com/dmitriim/moodle-local_helper  to local/helper:  git clone https: //github.com/dmitriim/moodle-local_helper.git local/helper Navigate to local/helper/index.php Open the links in that page ("Moodle Wiki example", "On click example 1" and "On click example 2"), and close these modal forms several times using ESC key on keyboard, Cancel button and close link. Confirm that all modal windows work without issues and you can close and open them as many times as you wish. 

      We have a custom plugin that broke after https://tracker.moodle.org/browse/MDL-67513 landed. 

      It seems like there is a regression that causes the issue if you have multiple modals on the same page. All previously opened  modals stay visible when you open up the next one.

      I wasn't able to replicate it in any of the core code (yet). But will try to supply a small plugin to replicate the issue. 

        1. 0001-Modal-movement-fix (2).patch
          9 kB
        2. MDL-70352.mp4
          1.25 MB

            dmitriim Dmitrii Metelkin
            dmitriim Dmitrii Metelkin
            Scott Verbeek Scott Verbeek
            Sara Arjona (@sarjona) Sara Arjona (@sarjona)
            Anna Carissa Sadia Anna Carissa Sadia
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 40 minutes
                40m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.