[MDL-70352] Modal forms stay on the screen if you have multiple modals on one page - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 3.9.4
Fix Version/s: 3.9.4, 3.10.1
Component/s: JavaScript
Labels:
- CatalystIT
- ci
- partner
- release_notes

Affected Branches:
MOODLE_39_STABLE
Fixed Branches:
MOODLE_310_STABLE, MOODLE_39_STABLE
Pull from Repository:
https://github.com/dmitriim/moodle
Pull 3.9 Branch:
~~MDL-70352~~-MOODLE_39_STABLE
Pull 3.9 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_39_STABLE...dmitriim:MDL-70352-MOODLE_39_STABLE
Pull 3.11 Branch:
~~MDL-70352~~-MOODLE_311_STABLE
Pull 3.11 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_311_STABLE...dmitriim:MDL-70352-MOODLE_311_STABLE
Pull Master Branch:
~~MDL-70352~~-master
Pull Master Diff URL:
https://github.com/moodle/moodle/compare/master...dmitriim:MDL-70352-master
Testing Instructions:
Hide

Install the helper plugin https://github.com/dmitriim/moodle-local_helper to local/helper:

git clone https://github.com/dmitriim/moodle-local_helper.git local/helper

Navigate to local/helper/index.php

Open the links in that page ("Moodle Wiki example", "On click example 1" and "On click example 2"), and close these modal forms several times using ESC key on keyboard, Cancel button and close link.

Confirm that all modal windows work without issues and you can close and open them as many times as you wish.
Show
Install the helper plugin https://github.com/dmitriim/moodle-local_helper to local/helper: git clone https: //github.com/dmitriim/moodle-local_helper.git local/helper Navigate to local/helper/index.php Open the links in that page ("Moodle Wiki example", "On click example 1" and "On click example 2"), and close these modal forms several times using ESC key on keyboard, Cancel button and close link. Confirm that all modal windows work without issues and you can close and open them as many times as you wish.

Description

We have a custom plugin that broke after https://tracker.moodle.org/browse/MDL-67513 landed.

It seems like there is a regression that causes the issue if you have multiple modals on the same page. All previously opened modals stay visible when you open up the next one.

I wasn't able to replicate it in any of the core code (yet). But will try to supply a small plugin to replicate the issue.

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

0001-Modal-movement-fix (2).patch
30/Nov/20 9:26 AM
9 kB
Dmitrii Metelkin
MDL-70352.mp4
13/Jan/21 10:25 AM
1.25 MB
Anna Carissa Sadia

Issue Links

is a regression caused by

MDL-67513 View conversation link does not work when grading in full screen mode

Closed

will help resolve

MDL-70395 Data Privacy use of core/modal_factory amd (triggerElement double event)

Closed

Activity

People

Assignee:: Dmitrii Metelkin

Reporter:: Dmitrii Metelkin

Peer reviewer:: Scott Verbeek

Integrator:: Sara Arjona (@sarjona)

Tester:: Anna Carissa Sadia

Participants:: Anna Carissa Sadia, CiBoT, Dmitrii Metelkin, Sara Arjona (@sarjona), Scott Verbeek

Component watchers:: David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo

Votes:: 0 Vote for this issue

Watchers:: 5 Start watching this issue

Dates

Created:: 30/Nov/20 9:21 AM

Updated:: 15/Jan/21 4:02 PM

Resolved:: 15/Jan/21 4:02 PM

Fix Release Date:: 18/Jan/21

Time Tracking

Estimated:

Not Specified

Remaining:

Logged:

40m