Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-70359

Nextcloud PDF files shared via controlled links that are displayed embedded in a file resource shows the complete site embedded and is then downloaded

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Waiting for peer review
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: 3.9.3
    • Fix Version/s: None
    • Component/s: Repositories, Resource
    • Labels:
    • Testing Instructions:
      Hide

      Create a nextcloud oauth2 service and a nextcloud repository. 

      https://demo.nextcloud.com/ is useful for this.

      Create a site wide instance of the nextcloud repository and only enable the "External" files.

      Add a PDF file to the course and choose it from the nextcloud repository.

      Edit the file and open the file picker again. Select the nextcloud repository and then press the small "Logout" button in the file picker.

      Go back to the course and view the file. You should see a button like "Login to your Nextcloud account" in an iframe in the course page. The iframe should not contain all the surrounding navigation like breadcrumbs, course header etc - it should only contain the button.

      Log in to nextcloud and the PDF should be displayed embedded into the page - it should not prompt you to download it.

      Show
      Create a nextcloud oauth2 service and a nextcloud repository.  https://demo.nextcloud.com/  is useful for this. Create a site wide instance of the nextcloud repository and only enable the "External" files. Add a PDF file to the course and choose it from the nextcloud repository. Edit the file and open the file picker again. Select the nextcloud repository and then press the small "Logout" button in the file picker. Go back to the course and view the file. You should see a button like "Login to your Nextcloud account" in an iframe in the course page. The iframe should not contain all the surrounding navigation like breadcrumbs, course header etc - it should only contain the button. Log in to nextcloud and the PDF should be displayed embedded into the page - it should not prompt you to download it.
    • Affected Branches:
      MOODLE_39_STABLE
    • Pull 3.9 Branch:
    • Pull 3.10 Branch:
      MDL-70359_310
    • Pull 3.11 Branch:
      MDL-70359_311
    • Pull Master Branch:
      MDL-70359_master

      Description

      See the attached images:
      Steps to reproduce

      1. Enable Nextcloud repository integration
      2. Go to a course and create a file resource:
        • Using the file picker, browse the Nextcloud repository and add a PDF file as a "controlled link / link to file"
        • Use the display options to embed the file
           

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              tschroeder Tim Schroeder
              Reporter:
              tschroeder Tim Schroeder
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan, Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan
              Votes:
              2 Vote for this issue
              Watchers:
              6 Start watching this issue

                Dates

                Created:
                Updated:

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 45 minutes
                  45m