Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-70361

LTI deeplinking: resourceid and tag not saved when returning multiple

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      In this test, we verify that graded links do preserve the resource id and tag in their lineitem definition by launching the test app graded link (which will query the lineitem and verify the presence of both of those attributes).

      pre-requisite

      1. LTI Advantage requires your site to be reachable from the internet. If not, Install ngrok to expose your moodle setup externally. Refer here for additional guidelines
      2. Have a course with an instructor.
      3. Have the Robotest Test app installed
        1. As site administrator, navigate to Site Admin > Plugins > Activity Modules > External Tool > Manage Tools
        2. In the box that says tool url enter: https://robotest.theedtech.dev/register
        3. Click the Add LTI Advantage button
        4. The test tool should open with a trace of the communication with Moodle, all should be green (thumbs up).
        5. Click the close button - the test app UI should disappear and the list of tools refreshing
        6. Verify the Robotest app has been added and is not yet activated
        7. Click the Activate button

      Verify resourceid and tag are preserved, single link return

      1. Enter a course as instructor
      2. Turn editing on and add activity>external tool
      3. In the drop box of tools, select Robotest
      4. Then verify Select Content is enabled, click on it
      5. Verify the tool UI opens. Select a graded  item.
      6. Verify you are returned to the external tool interface successfully
      7. Click Save and Display
      8. Verify the tool shows up and no errors are reported.

      Verify resourceid and tag are preserved, multiple links return

      1. Enter a course as instructor
      2. Turn editing on and add activity>external tool
      3. In the drop box of tools, select Robotest
      4. Then verify Select Content is enabled, click on it
      5. Verify the tool UI opens. Select Both of them.
      6. Verify you are returned to the external tool interface successfully
      7. Click Save and Return to Course
      8.  Click on each of the links added (graded, not graded) and verify the tool shows up and no errors are reported.
      Show
      In this test, we verify that graded links do preserve the resource id and tag in their lineitem definition by launching the test app graded link (which will query the lineitem and verify the presence of both of those attributes). pre-requisite LTI Advantage requires your site to be reachable from the internet. If not, Install ngrok to expose your moodle setup externally. Refer here for additional guidelines Have a course with an instructor. Have the Robotest Test app installed As site administrator, navigate to Site Admin > Plugins > Activity Modules > External Tool > Manage Tools In the box that says tool url enter: https://robotest.theedtech.dev/register Click the Add LTI Advantage button The test tool should open with a trace of the communication with Moodle, all should be green (thumbs up). Click the close button - the test app UI should disappear and the list of tools refreshing Verify the Robotest app has been added and is not yet activated Click the Activate button Verify resourceid and tag are preserved, single link return Enter a course as instructor Turn editing on and add activity>external tool In the drop box of tools, select Robotest Then verify Select Content is enabled, click on it Verify the tool UI opens. Select a graded  item. Verify you are returned to the external tool interface successfully Click Save and Display Verify the tool shows up and no errors are reported. Verify resourceid and tag are preserved, multiple links return Enter a course as instructor Turn editing on and add activity>external tool In the drop box of tools, select Robotest Then verify Select Content is enabled, click on it Verify the tool UI opens. Select Both of them. Verify you are returned to the external tool interface successfully Click Save and Return to Course  Click on each of the links added (graded, not graded) and verify the tool shows up and no errors are reported.
    • Affected Branches:
      MOODLE_310_STABLE
    • Fixed Branches:
      MOODLE_310_STABLE
    • Pull from Repository:
    • Pull 3.10 Branch:
      MDL-70361-dlrlid-310
    • Pull 3.11 Branch:
      MDL-70361-dlrlid-311
    • Pull Master Branch:
      MDL-70361-dlrlid

      Description

      When creating multiple links at a time, the resourceid and tag for the lineitem are not saved, possibly impairing the tool to do any grade post.

       

      Note: I've updated the robotest app to test that case, see testing instructions.

        Attachments

        1. Screenshot_1.jpg
          Screenshot_1.jpg
          39 kB
        2. Screenshot_2.jpg
          Screenshot_2.jpg
          64 kB
        3. Screenshot_3.jpg
          Screenshot_3.jpg
          92 kB

          Activity

            People

            Assignee:
            claudevervoort Claude Vervoort
            Reporter:
            claudevervoort Claude Vervoort
            Peer reviewer:
            Jake Dallimore Jake Dallimore
            Integrator:
            Jun Pataleta Jun Pataleta
            Tester:
            Janelle Barcega Janelle Barcega
            Participants:
            Component watchers:
            Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              9/Nov/20

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 4 hours, 30 minutes
                4h 30m