[MDL-70362] Add showdebugging and showsql options to admin/cli/uninstall_plugins.php - Moodle Tracker

XML

Word

Printable

Details

Type: Improvement
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 3.9.3, 3.10, 3.11, 4.0
Fix Version/s: 3.11
Component/s: Administration
Labels:
- CatalystIT
- ci
- partner
- release_notes

Affected Branches:
MOODLE_310_STABLE, MOODLE_311_STABLE, MOODLE_39_STABLE, MOODLE_400_STABLE
Fixed Branches:
MOODLE_311_STABLE
Pull from Repository:
https://github.com/golenkovm/moodle
Pull 3.11 Branch:
MOODLE_311_~~MDL-70362~~
Pull 3.11 Diff URL:
https://github.com/moodle/moodle/compare/21c367cee68a3...golenkovm:MOODLE_311_MDL-70362
Pull Master Branch:
master-~~MDL-70362~~
Pull Master Diff URL:
https://github.com/moodle/moodle/compare/4ec279a2f063ae...golenkovm:master-MDL-70362

Testing Instructions:

Hide

1. Turn off debugging:

php admin/cli/cfg.php --name=debug --set=0

2. Run the command from CLI:

php admin/cli/uninstall_plugins.php

3. Confirm, that help section has showsql and showdebugging mentioned.

4. Run the command from CLI:

php admin/cli/uninstall_plugins.php --plugins=auth_none --showsql

5. Confirm, that the output shows SQLs.

6. In order to emulate exception, edit /admin/cli/uninstall_plugins.php file and add the following code here (line 103):

throw new coding_exception("Test");

7. Run the command from CLI:

php admin/cli/uninstall_plugins.php --plugins=auth_none --showdebugging

8. Confirm, that the output shows debugging, something similar to:

Default exception handler: Coding error detected, it must be fixed by a programmer: Test Debug:

Error code: codingerror

* line 103 of /admin/cli/uninstall_plugins.php: coding_exception thrown

!!! Coding error detected, it must be fixed by a programmer: Test !!!

!!

Error code: codingerror !!

!! Stack trace: * line 103 of /admin/cli/uninstall_plugins.php: coding_exception thrown

!!

Show

1. Turn off debugging: php admin/cli/cfg.php --name=debug --set= 0 2. Run the command from CLI: php admin/cli/uninstall_plugins.php 3. Confirm , that help section has showsql and showdebugging mentioned. 4. Run the command from CLI: php admin/cli/uninstall_plugins.php --plugins=auth_none --showsql 5. Confirm , that the output shows SQLs. 6. In order to emulate exception, edit /admin/cli/uninstall_plugins.php file and add the following code here (line 103): throw new coding_exception( "Test" ); 7. Run the command from CLI: php admin/cli/uninstall_plugins.php --plugins=auth_none --showdebugging 8. Confirm , that the output shows debugging, something similar to: Default exception handler: Coding error detected, it must be fixed by a programmer: Test Debug: Error code: codingerror * line 103 of /admin/cli/uninstall_plugins.php: coding_exception thrown !!! Coding error detected, it must be fixed by a programmer: Test !!! !! Error code: codingerror !! !! Stack trace: * line 103 of /admin/cli/uninstall_plugins.php: coding_exception thrown !!

Description

Investigating long running "admin/cli/uninstall_plugins.php" CLI I found that it doesn't have showdebugging and showsql options as other CLI do.

Would be good to add these two options.

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

MDL-70362_Screenshot.PNG
188 kB
14/Jan/21 12:48 PM

Activity

People

Assignee:: Misha Golenkov

Reporter:: Misha Golenkov

Peer reviewer:: Dmitrii Metelkin

Integrator:: Sara Arjona (@sarjona)

Tester:: Anna Carissa Sadia

Participants:: Anna Carissa Sadia, CiBoT, Dmitrii Metelkin, Misha Golenkov, Sara Arjona (@sarjona)

Component watchers:: David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo

Votes:: 0 Vote for this issue

Watchers:: 5 Start watching this issue

Dates

Created:: 01/Dec/20 11:40 AM

Updated:: 15/Jan/21 4:01 PM

Resolved:: 15/Jan/21 4:01 PM

Fix Release Date:: 17/May/21

Time Tracking

Estimated:

Remaining:

Logged:

1h 20m