Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-70377

When reviewing an attempt as a teacher $string['saved'] {$a} not replaced

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      To test this you need to:

      1. Create a course
      2. On this course you need at least one student and one editing teacher/admin.
      3. Create various essay questions in the question banks as follow:
      4. Essay1 (with text input required and no attachments).
      5. Essay2 (with text input required and any number of attachments).
      6. Essay3 (with text input is NOT required but any number of attachments).
      7. Then maybe for clarity, create 3 quizzes for each to contain a corresponding question (for instance, Quiz1 contains Essay1, Quiz2 contains Essay2, etc.)
      8. Student attempts the Quizzes and submit their responses.
      9. Teacher view quiz attempts and then review attempts (See description).
      10. Then the teacher should see the following in the response history table on action Saved:
      11. Saved: the input text from student (for Essay1)
      12. Saved: the input text from student Attachments: filename1 (filesize1), filename2 (filesize2), etc. (for Essay2)
      13. Saved: Attachments: filename1 (filesize1), filename2 (filesize2), etc. (for Essay3)
        Obviously, filename is displayed as name.extension, and the filesize is displayed as formatted by display_size() in /lib/moodlelib.php (eg. 20KB or 4.6MB)
      Show
      To test this you need to: Create a course On this course you need at least one student and one editing teacher/admin. Create various essay questions in the question banks as follow: Essay1 (with text input required and no attachments). Essay2 (with text input required and any number of attachments). Essay3 (with text input is NOT required but any number of attachments). Then maybe for clarity, create 3 quizzes for each to contain a corresponding question (for instance, Quiz1 contains Essay1, Quiz2 contains Essay2, etc.) Student attempts the Quizzes and submit their responses. Teacher view quiz attempts and then review attempts (See description). Then the teacher should see the following in the response history table on action Saved: Saved: the input text from student (for Essay1) Saved: the input text from student Attachments: filename1 (filesize1), filename2 (filesize2), etc. (for Essay2) Saved: Attachments: filename1 (filesize1), filename2 (filesize2), etc. (for Essay3) Obviously, filename is displayed as name.extension, and the filesize is displayed as formatted by display_size() in /lib/moodlelib.php (eg. 20KB or 4.6MB)
    • Affected Branches:
      MOODLE_39_STABLE
    • Fixed Branches:
      MOODLE_310_STABLE, MOODLE_39_STABLE
    • Pull 3.9 Branch:
    • Pull 3.10 Branch:
      MDL-70377_310
    • Pull 3.11 Branch:
      MDL-70377_311
    • Pull Master Branch:

      Description

      1. Create a quiz
      1. Add Essay question type - 
        Response format - No online text
        Allow Attachments
        Require Attachment 1
        Required file type (select as desired)
      2. Take quiz
      3. As a teacher, view attempts
      4. Review attempt

      Response history

      Step Time Action State Marks
      1 2/12/20, 14:32 Started Not yet answered
      2 2/12/20, 14:32 Saved: {$a} Answer saved
      3 2/12/20, 14:33 Attempt finished Complete

      Action response does not evaluate {$a}

        Attachments

        1. Screenshot_1.jpg
          42 kB
          Janelle Barcega
        2. Screenshot_2.jpg
          46 kB
          Janelle Barcega

          Activity

            People

            Assignee:
            mkassaei Mahmoud Kassaei
            Reporter:
            katcher Eric Katchan
            Peer reviewer:
            Tim Hunt Tim Hunt
            Integrator:
            Sara Arjona (@sarjona) Sara Arjona (@sarjona)
            Tester:
            Janelle Barcega Janelle Barcega
            Participants:
            Component watchers:
            Tim Hunt, Andrew Lyons, Dongsheng Cai, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
            Votes:
            1 Vote for this issue
            Watchers:
            5 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              8/Mar/21

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 2 hours, 5 minutes
                2h 5m