Details
-
Type:
Bug
-
Status: Closed
-
Priority:
Minor
-
Resolution: Fixed
-
Affects Version/s: 3.9.3, 3.10
-
Component/s: Chat
-
Testing Instructions:
- Setup a course with a chat, and two users
- Join the chat as each of the users, in different browsers
- Confirm chat works as expected
-
Affected Branches:MOODLE_310_STABLE, MOODLE_39_STABLE
-
Fixed Branches:MOODLE_310_STABLE, MOODLE_39_STABLE
-
Pull from Repository:
-
Pull 3.9 Branch:
MDL-70409-39 -
Pull 3.9 Diff URL:
-
Pull 3.10 Branch:
MDL-70409-310 -
Pull 3.10 Diff URL:
-
Pull 3.11 Branch:
MDL-70409-311 -
Pull 3.11 Diff URL:
-
Pull Master Branch:
MDL-70409-master -
Pull Master Diff URL:
Description
A few pages in chat use require() instead of require_once() to import their lib.php.
This will cause the chat to break if mod/chat/lib.php is imported earlier in the page load - as can happen with certain filters (like Ally).
I did a quick grep, and this is the only place in core where a mod imports its lib.php using require().
