Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-70436

On mobile, the Quiz confirmation modal has it's close button cut off

    XMLWordPrintable

Details

    • MOODLE_310_STABLE, MOODLE_311_STABLE, MOODLE_39_STABLE, MOODLE_400_STABLE
    • MOODLE_310_STABLE, MOODLE_39_STABLE
    • MDL-70436-master
    • Hide
      1. Login as admin
      2. Create a new course with a quiz activity
      3. Add one question to the quiz
      4. Attempt the quiz
      5. Now switch the browser size to a mobile size (767px width or lower)
      6. Click the "Submit all and finish" button
      7. Verify the dialog close button has sufficient padding similar to the screenshot below
      Show
      Login as admin Create a new course with a quiz activity Add one question to the quiz Attempt the quiz Now switch the browser size to a mobile size (767px width or lower) Click the "Submit all and finish" button Verify the dialog close button has sufficient padding similar to the screenshot below

    Description

      There's some CSS that appears to be trying to make the modal close button smaller on mobile devices.

      Most browsers seem to just ignore this, but Safari tries to follow it, and as a result cuts off the X used to close the modal since it extends beyond the size set. I'm not sure making this button smaller is a good idea, since people might be trying to hit it with their finger on mobile devices.

      Possibly just deleting this line is the right fix?

      .moodle-dialogue-base .moodle-dialogue-fullscreen .closebutton

      { width: 28px; height: 16px; background-size: 100%; }

       

      Attachments

        Activity

          People

            basbrands Bas Brands
            bawjaws David Scotson
            Tim Hunt Tim Hunt
            Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
            Janelle Barcega Janelle Barcega
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Time Tracking

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 1 hour, 14 minutes
                1h 14m

                Clockify

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.