Details
-
Type:
Bug
-
Status: Waiting for peer review
-
Priority:
Minor
-
Resolution: Unresolved
-
Affects Version/s: 3.9.3
-
Fix Version/s: None
-
Component/s: Assignment
-
Testing Instructions:
-
Affected Branches:MOODLE_39_STABLE
-
Pull from Repository:
-
Pull Master Branch:MDL-70441_workflow-state_master
-
Pull Master Diff URL:
Description
My group has a different role for grading assignments (mod/assign:grade) than for releasing the grades (mod/assign:releasegrades, mod/assign:managegrades).
With the current workflow code, this split results in the graders not being shown the correct workflow state for any assignment which has been released. Due to get_marking_workflow_states_for_current_user() not including "Released" in their list of workflow states, it defaults to "Not marked". "Helpful" graders have gone on to reset the state from "Released" to "Marking completed", preventing students from seeing their results.
Scenario:
- A Grader role with mod/assign:grade (but not mod/assign:releasegrades or mod/assign:managegrades).
- An Admin role with mod/assign:releasegrades and/or mod/assign:managegrades.
- A Student has submitted an assignemnt
- The Grader has marked it.
- The Admin has released it.
- The Grade views the assignment again...
Expected results:
The Grader sees that the Workflow state is "Released", and cannot change it.
Actual results:
The Grader sees that the Workflow state is "Not marked", and can revert the grade back from "Released".