Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-70441

Wrong workflow state shown to graders who can't release grades

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Waiting for peer review
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: 3.9.3
    • Fix Version/s: None
    • Component/s: Assignment
    • Labels:
    • Testing Instructions:
      Hide

      Scenario:

      1. Create/modify a Grader role with mod/assign:grade - but not mod/assign:releasegrades or mod/assign:managegrades.
      2. Create/modify an Admin role with mod/assign:releasegrades and/or mod/assign:managegrades.
      3. Create an assignment and have a student submit it.
      4. As the Grader mark it.
      5. As the Admin set the workflow state to Released.
      6. As the Grader view the assignment again.

      Expected results:

      The Grader sees that the Workflow state is "Released", and cannot change it.

       

      Show
      Scenario: Create/modify a Grader role with mod/assign:grade - but not mod/assign:releasegrades or mod/assign:managegrades. Create/modify an Admin role with mod/assign:releasegrades and/or mod/assign:managegrades. Create an assignment and have a student submit it. As the Grader mark it. As the Admin set the workflow state to Released. As the Grader view the assignment again. Expected results: The Grader sees that the Workflow state is "Released", and cannot change it.  
    • Affected Branches:
      MOODLE_39_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-70441_workflow-state_master

      Description

      My group has a different role for grading assignments (mod/assign:grade) than for releasing the grades (mod/assign:releasegrades, mod/assign:managegrades).

      With the current workflow code, this split results in the graders not being shown the correct workflow state for any assignment which has been released. Due to get_marking_workflow_states_for_current_user() not including "Released" in their list of workflow states, it defaults to "Not marked". "Helpful" graders have gone on to reset the state from "Released" to "Marking completed", preventing students from seeing their results.

      Scenario:

      1. A Grader role with mod/assign:grade (but not mod/assign:releasegrades or mod/assign:managegrades).
      2. An Admin role with mod/assign:releasegrades and/or mod/assign:managegrades.
      3. A Student has submitted an assignemnt
      4. The Grader has marked it.
      5. The Admin has released it.
      6. The Grade views the assignment again...

      Expected results:

      The Grader sees that the Workflow state is "Released", and cannot change it.

      Actual results:

      The Grader sees that the Workflow state is "Not marked", and can revert the grade back from "Released".

        Attachments

          Activity

            People

            Assignee:
            Unassigned Unassigned
            Reporter:
            balchd Dave Balch
            Participants:
            Component watchers:
            Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Dates

              Created:
              Updated: