Loading...

XML

Word

Printable

Affected Branches:
MOODLE_310_STABLE, MOODLE_39_STABLE
Fixed Branches:
MOODLE_310_STABLE, MOODLE_39_STABLE
Pull from Repository:
https://github.com/stronk7/moodle.git
Pull Main Branch:
~~MDL-70457~~
Pull Main Diff URL:
https://github.com/stronk7/moodle/compare/MDL-70457~1...MDL-70457
Difficulty:
Easy
Testing Instructions:
Hide

Before the patch

Using PHP 7.4

Copy the attached test70457.php file to the moodle-root directory.

From terminal, execute it (php test70457.php).

Verify that you get the PHP deprecation notices: Deprecated: Array and string offset access syntax with curly braces is deprecated in ... lib/pear/HTML/QuickForm/date.php on line ...

After the patch

Repeat steps 1-3 from "Before the patch".

Verify that there aren't deprecation notices anymore.
Show
Before the patch Using PHP 7.4 Copy the attached test70457.php file to the moodle-root directory. From terminal, execute it ( php test70457.php ). Verify that you get the PHP deprecation notices: Deprecated: Array and string offset access syntax with curly braces is deprecated in ... lib/pear/HTML/QuickForm/date.php on line ... After the patch Repeat steps 1-3 from "Before the patch". Verify that there aren't deprecation notices anymore.

$sign = $this->_options['format']{$i};

needs to be changed to

$sign = $this->_options['format'][$i];

Participants:: Amaia Anabitarte, Anna Carissa Sadia, CiBoT, Eloy Lafuente (stronk7), James Kinsman, Jun Pataleta, muditsinghal, Sara Arjona (@sarjona)

Estimated:

Not Specified

Remaining:

Logged:

3h 35m