[MDL-70482] Missing closing bracket in the search_input_navbar template - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 3.10
Fix Version/s: 3.10.1
Component/s: Themes
Labels:
- ci
- triaged

Testing Instructions:
Hide

Login as admin

Navigate to Site Administration > Advanced features

Check the "Enable global search" option

Save changes

Click the search icon in the top navbar

Type "test" in the search input box and click the search icon again

Verify you are now on the "Global Search" page showing your search query "test"
Show
Login as admin Navigate to Site Administration > Advanced features Check the "Enable global search" option Save changes Click the search icon in the top navbar Type "test" in the search input box and click the search icon again Verify you are now on the "Global Search" page showing your search query "test"
Affected Branches:
MOODLE_310_STABLE
Fixed Branches:
MOODLE_310_STABLE
Pull from Repository:
https://github.com/sebmehr/moodle.git
Pull 3.10 Branch:
~~MDL-70482~~_310_STABLE
Pull 3.10 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_310_STABLE...sebmehr:MDL-70482_310_STABLE
Pull Master Branch:
~~MDL-70482~~_master
Pull Master Diff URL:
https://github.com/moodle/moodle/compare/master...sebmehr:MDL-70482_master

Description

There is a missing closing bracket in the script that handling interactions with the search form in the navbar :

https://github.com/moodle/moodle/blob/master/lib/templates/search_input_navbar.mustache#L98

In some cases, it causes an error in the browser console log, specially when additionnal filters are installed.

Attachments

Options
- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

Attachments

global_search_310branch.png
62 kB
07/Jan/21 11:39 AM
global_search_311branch.png
62 kB
07/Jan/21 11:40 AM
global_search_masterbranch.png
56 kB
07/Jan/21 11:38 AM
global_search_masterbranch-1.png
63 kB
07/Jan/21 11:43 AM

Activity

People

Assignee:: Sébastien Mehr

Reporter:: Sébastien Mehr

Integrator:: Adrian Greeve

Tester:: Sujith Haridasan

Participants:: Adrian Greeve, Bas Brands, CiBoT, Eloy Lafuente (stronk7), Sébastien Mehr, Sujith Haridasan

Component watchers:: Bas Brands

Votes:: 0 Vote for this issue

Watchers:: 4 Start watching this issue

Dates

Created:: 16/Dec/20 9:15 PM

Updated:: 08/Jan/21 10:36 PM

Resolved:: 08/Jan/21 1:43 PM

Fix Release Date:: 18/Jan/21

Time Tracking

Estimated:

Not Specified

Remaining:

0m

Logged:

3d 3h