Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-70482

Missing closing bracket in the search_input_navbar template

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • Minor
    • 3.10.1
    • 3.10
    • Themes
    • MOODLE_310_STABLE
    • MOODLE_310_STABLE
    • MDL-70482_master
    • Hide

       

      1. Login as admin
      2. Navigate to Site Administration > Advanced features
      3. Check the "Enable global search" option
      4. Save changes
      5. Click the search icon in the top navbar
      6. Type "test" in the search input box and click the search icon again
      7. Verify you are now on the "Global Search" page showing your search query "test"
      Show
        Login as admin Navigate to Site Administration > Advanced features Check the "Enable global search" option Save changes Click the search icon in the top navbar Type "test" in the search input box and click the search icon again Verify you are now on the "Global Search" page showing your search query "test"

    Description

      There is a missing closing bracket in the script that handling interactions with the search form in the navbar :

      https://github.com/moodle/moodle/blob/master/lib/templates/search_input_navbar.mustache#L98

      In some cases, it causes an error in the browser console log, specially when additionnal filters are installed.

      Attachments

        1. global_search_310branch.png
          62 kB
          Sujith Haridasan
        2. global_search_311branch.png
          62 kB
          Sujith Haridasan
        3. global_search_masterbranch.png
          56 kB
          Sujith Haridasan
        4. global_search_masterbranch-1.png
          63 kB
          Sujith Haridasan

        Activity

          People

            sebmehr Sébastien Mehr
            sebmehr Sébastien Mehr
            Adrian Greeve Adrian Greeve
            Sujith Haridasan Sujith Haridasan
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 3 days, 3 hours
                3d 3h

                Clockify

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.