Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-70494

Forum: deprecate unused string 'privacy:request:delete:post:message'

XMLWordPrintable

    • Icon: Improvement Improvement
    • Resolution: Fixed
    • Icon: Minor Minor
    • 4.5
    • 3.11, 4.5
    • Forum
    • MOODLE_311_STABLE, MOODLE_405_STABLE
    • MOODLE_405_STABLE
    • MDL-70494-main
    • Hide
      1. Run the following command in the terminal:

        grep -R 'privacy:request:delete' mod/forum/ -B1

      2. Ensure only mod/forum/lang/en/deprecated.txt and mod/forum/lang/en/forum.php
      3. In mod/forum/lang/en/forum.php ensure results are under '// Deprecated since Moodle 4.5.'
      Show
      Run the following command in the terminal: grep -R 'privacy:request:delete' mod/forum/ -B1 Ensure only mod/forum/lang/en/deprecated.txt and mod/forum/lang/en/forum.php In mod/forum/lang/en/forum.php ensure results are under '// Deprecated since Moodle 4.5.'
    • 1
    • Team Alpha - Planning I2-2024

      In addressing the test_mod_forum_get_forum_discussion_posts_deleted() method in MDL-65252, I noted that the 'privacy:request:delete:post:message' string can probably now be deprecated, since it's no longer used. The string 'privacy:request:delete:post:subject' appears to be in use still, in mod/forum/rsslib.php, however. Not sure why this was being used in the regular deletion stuff, but a quick grep revealed it wasn't in use once that test method was updated.

            ilyatregubov Ilya Tregubov
            jaked Jake Dallimore
            Mihail Geshoski Mihail Geshoski
            Sara Arjona (@sarjona) Sara Arjona (@sarjona)
            Kim Jared Lucas Kim Jared Lucas
            Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 1 hour, 47 minutes
                1h 47m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.