Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-70496

get_discussion_posts does not include the 'messagetrust' field

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Unresolved
    • Icon: Minor Minor
    • None
    • 3.9.3, 3.10, 3.11
    • Forum
    • None
    • MOODLE_310_STABLE, MOODLE_311_STABLE, MOODLE_39_STABLE

      In MDL-65252, as part of deprecation of "get_forum_discussion_posts" we had to change the test methods "test_trusted_text_enabled" and "test_trusted_text_disabled" after changing their usages of "get_forum_discussion_posts" to the recommended replacement method "get_discussion_posts". This was because the data we needed to assert was present, was not.  Namely, lines like this:

      $this->assertEquals(1, $posts['posts'][0]['messagetrust']); 

      That field just isn't present in the returns of the replacement method.

      This issue is about working out whether or not that's expected. I'm not sure why it was there in the original method, but we certainly had tests covering it and the replacement should probably also return it (right?).

            Unassigned Unassigned
            jaked Jake Dallimore
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.