[MDL-70520] Moodle upgrade resets scheduled tasks lastruntime - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 3.9.3, 3.10, 3.11, 4.0
Fix Version/s: 3.9.4, 3.10.1
Component/s: Administration, Tasks
Labels:
- CatalystIT
- ci
- partner
- release_notes
- triaged

Affected Branches:
MOODLE_310_STABLE, MOODLE_311_STABLE, MOODLE_39_STABLE, MOODLE_400_STABLE
Fixed Branches:
MOODLE_310_STABLE, MOODLE_39_STABLE
Pull from Repository:
https://github.com/golenkovm/moodle
Pull 3.9 Branch:
MOODLE_39_~~MDL-70520~~
Pull 3.9 Diff URL:
https://github.com/moodle/moodle/compare/ef8eb8ef1a1892...golenkovm:MOODLE_39_MDL-70520
Pull 3.11 Branch:
MOODLE_311_~~MDL-70520~~
Pull 3.11 Diff URL:
https://github.com/moodle/moodle/compare/21c367cee68a3c...golenkovm:MOODLE_311_MDL-70520
Pull Master Branch:
master_~~MDL-70520~~
Pull Master Diff URL:
https://github.com/moodle/moodle/compare/4ec279a2f063ae...golenkovm:master_MDL-70520
Testing Instructions:
Hide

1) Run scheduled task:

php admin/cli/scheduled_task.php --execute='\mod_assign\task\cron_task'

2) Confirm, that lastruntime is set for the task:

moodle=# select lastruntime from mdl_task_scheduled where component = 'mod_assign';

lastruntime

-------------

1608536830

(1 row)

3) Increment version number for the mod_assign plugin.

4) Run upgrade from CLI:

php admin/cli/upgrade.php

5) Confirm, that lastruntime hasn't been reset:

moodle=# select lastruntime from mdl_task_scheduled where component = 'mod_assign';

lastruntime

-------------

1608536830

(1 row)
Show
1) Run scheduled task: php admin/cli/scheduled_task.php --execute= '\mod_assign\task\cron_task' 2) Confirm , that lastruntime is set for the task: moodle=# select lastruntime from mdl_task_scheduled where component = 'mod_assign' ; lastruntime ------------- 1608536830 ( 1 row) 3) Increment version number for the mod_assign plugin. 4) Run upgrade from CLI: php admin/cli/upgrade.php 5) Confirm , that lastruntime hasn't been reset: moodle=# select lastruntime from mdl_task_scheduled where component = 'mod_assign' ; lastruntime ------------- 1608536830 ( 1 row)

Description

Upgrade script resets scheduled tasks.

As part of this reset `nextruntime` is kept, but `lastruntime` is being set to 0.

This can lead to some issues. For example `\mod_assign\task\cron_task` task checks its last time run https://github.com/moodle/moodle/blob/4ec279a2f063ae890804126e4886f87fe83b5cea/mod/assign/locallib.php#L2521 and then selects records to be processed based on returned value: https://github.com/moodle/moodle/blob/4ec279a2f063ae890804126e4886f87fe83b5cea/mod/assign/locallib.php#L2696-L2697 so when lastruntime equals 0, the task gets all records including those ones which were already processed as part of previous runs.

Attachments

Activity

People

Assignee:: Misha Golenkov

Reporter:: Misha Golenkov

Peer reviewer:: Brendan Heywood

Integrator:: Eloy Lafuente (stronk7)

Tester:: Eloy Lafuente (stronk7)

Participants:: Amaia Anabitarte, Brendan Heywood, CiBoT, Eloy Lafuente (stronk7), Misha Golenkov

Component watchers:: David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo, David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo

Votes:: 0 Vote for this issue

Watchers:: 5 Start watching this issue

Dates

Created:: 21/Dec/20 3:01 PM

Updated:: 12/Jan/21 5:24 PM

Resolved:: 08/Jan/21 1:43 PM

Fix Release Date:: 18/Jan/21

Time Tracking

Estimated:

Remaining:

Logged:

30m