Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-70535

videojs language doesn't fallback to en

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      1. Login as admin
      2. Navigate to Language > Language packs in site administration
      3. Install the Spanish (International) (es) and Lithuanian (lt) language packs
      4. Create a new course
      5. Add a new label activity with the following Label text (insert as a link):

        https://www.youtube.com/watch?v=3ORsUGVNxGs
        

      6. Press Save and return to course
      7. View the course page
      8. Play the video
      9. Confirm the video loads without an exception and hovering over the player controls shows the tooltips in English
      10. From the Language selector in the page header, select Spanish
      11. Repeat steps 7-8, confirm the video tooltips are in Spanish
      12. From the Language selector in the page header, select Lithuanian
      13. Repeat steps 7-8, confirm the video tooltips are in English
      Show
      Login as admin Navigate to Language > Language packs in site administration Install the Spanish (International) (es) and Lithuanian (lt) language packs Create a new course Add a new label activity with the following Label text (insert as a link): https://www.youtube.com/watch?v=3ORsUGVNxGs Press Save and return to course View the course page Play the video Confirm the video loads without an exception and hovering over the player controls shows the tooltips in English From the Language selector in the page header, select Spanish Repeat steps 7-8, confirm the video tooltips are in Spanish From the Language selector in the page header, select Lithuanian Repeat steps 7-8, confirm the video tooltips are in English
    • Affected Branches:
      MOODLE_310_STABLE
    • Fixed Branches:
      MOODLE_310_STABLE
    • Pull 3.10 Branch:
      MDL-70535-310
    • Pull 3.11 Branch:
      MDL-70535-311
    • Pull Master Branch:

      Description

      videojs language doesn't fallback to en when using language not in videojs lang folder

      1. # Log in as admin
      2. Install the Lithuanian(lt) language pack (videojs doesn't have lang files for this language )
      3. Go into a course and create a page
      4. In Page content click the video link in atto
      5. Then select Video tab.
      6. Insert a small video file into the page (.mp4) formats or Youtube link
      7. Save changes and visit the page
      8. Switch Moodle language to Lithuanian
      9. Check the page that contains the videos again
      10. Syntax error

      SyntaxError: Unexpected end of JSON input at JSON.parse (<anonymous>) at http://drupal.docker.localhost:8000/lib/requirejs.php/-1/media_videojs/loader.js:1:3642 at mightThrow (http://drupal.docker.localhost:8000/lib/javascript.php/-1/lib/jquery/jquery-3.4.1.js:3557:29) at process (http://drupal.docker.localhost:8000/lib/javascript.php/-1/lib/jquery/jquery-3.4.1.js:3625:12)

        Attachments

        1. bugmore4.jpg
          bugmore4.jpg
          23 kB
        2. MDL-70535.jpg
          MDL-70535.jpg
          84 kB

          Issue Links

            Activity

              People

              Assignee:
              pholden Paul Holden
              Reporter:
              arvvns Arv Vns
              Peer reviewer:
              Peter Dias Peter Dias
              Integrator:
              Sara Arjona (@sarjona) Sara Arjona (@sarjona)
              Tester:
              Anna Carissa Sadia Anna Carissa Sadia
              Participants:
              Component watchers:
              Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona), Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona)
              Votes:
              4 Vote for this issue
              Watchers:
              10 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                8/Mar/21

                  Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 2 hours, 5 minutes
                  2h 5m