Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-70579

Site fullname not filtered when downloading course content

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Configure multilang site full name

      1. Log in as admin
      2. Navigate to Site administration > Front page > Front page settings in Site administration
      3. Set Full site name to the following:

        <span class="multilang" lang="en">Moodle (EN)</span><span class="multilang" lang="de">Moodle (DE)</span>
        

      4. Navigate to Plugins > Filters > Manage filters in Site administration
      5. Set Multi-Language Content to On & Apply to to Content and headings
      6. Perform sanity check by visiting Site home and confirming the site heading shows "Moodle (EN)" and not "Moodle (DE)"

      Download course content

      1. Navigate to Courses > Download course content in site administration
      2. Enable Download course content feature available
      3. Create a new course, setting Enable download course content to Yes
      4. In your new course Actions menu select Download course content
      5. Extract the downloaded archive
      6. Open the index.html file within the extracted content
      7. Confirm the page title and heading are Moodle Master (EN) (and multilang tags have been filtered out)
      Show
      Configure multilang site full name Log in as admin Navigate to Site administration > Front page > Front page settings in Site administration Set Full site name to the following: <span class="multilang" lang="en">Moodle (EN)</span><span class="multilang" lang="de">Moodle (DE)</span> Navigate to Plugins > Filters > Manage filters in Site administration Set Multi-Language Content to On & Apply to to Content and headings Perform sanity check by visiting Site home and confirming the site heading shows "Moodle (EN)" and not "Moodle (DE)" Download course content Navigate to Courses > Download course content in site administration Enable Download course content feature available Create a new course, setting Enable download course content to Yes In your new course Actions menu select Download course content Extract the downloaded archive Open the index.html file within the extracted content Confirm the page title and heading are Moodle Master (EN) (and multilang tags have been filtered out)
    • Affected Branches:
      MOODLE_310_STABLE
    • Fixed Branches:
      MOODLE_310_STABLE
    • Pull 3.10 Branch:
      MDL-70579-310
    • Pull 3.11 Branch:
      MDL-70579-311
    • Pull Master Branch:

      Description

      Multilang tags within the site fullname are not filtered when using the course download functionality, leading to mangled HTML in the downloaded file:

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              pholden Paul Holden
              Reporter:
              pholden Paul Holden
              Peer reviewer:
              Peter Dias Peter Dias
              Integrator:
              Andrew Lyons Andrew Lyons
              Tester:
              Janelle Barcega Janelle Barcega
              Participants:
              Component watchers:
              Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona)
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                8/Mar/21

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 1 hour, 45 minutes
                  1h 45m