Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-70580

Privacy export tree navigation non-functional since MDL-69559

XMLWordPrintable

    • MOODLE_310_STABLE
    • MOODLE_310_STABLE
    • Hide

      Privacy export

      1. Login as admin
      2. Navigate to Users > Privacy and policies > Privacy settings in site administration
      3. Enable Contact the privacy officer
      4. Navigate to your profile
      5. Under Privacy and policies press Export all of my personal data
      6. Press Save changes
      7. Navigate to Users > Privacy and policies > Data requests in site administration
      8. Click Actions > Approve request and confirm the dialogue for your new request
      9. Wait for cron to process the request (or trigger it manually from wwwroot via command line with php admin/cli/cron.php ).
      10. Press Actions > Download for your new request
      11. Extract the downloaded file
      12. Open index.html in the root of the extracted file location
      13. Confirm you can expand/collapse multiple levels of navigation successfully (eg expanding a child node does not collapse the parent)

      Regression test (see MDL-69559 and MDL-70033)

      1. Enable course content download in a course
      2. Switch to Classic theme
      3. From Course administration click on Download course content with your mouse
      4. Confirm Download course content modal appears
      5. Click Download and confirm down browser prompts to download archive
      6. Using your keyboard to navigate the Course administration tree press Enter on the Download course content link
      7. Confirm modal appears and you can download file
      8. Using your keyboard to navigate the Course administration tree press Space on the Download course content link
      9. Confirm modal appears and you can download file
      Show
      Privacy export Login as admin Navigate to Users > Privacy and policies > Privacy settings in site administration Enable Contact the privacy officer Navigate to your profile Under Privacy and policies press Export all of my personal data Press Save changes Navigate to Users > Privacy and policies > Data requests in site administration Click Actions > Approve request and confirm the dialogue for your new request Wait for cron to process the request (or trigger it manually from wwwroot via command line with php admin/cli/cron.php  ). Press Actions > Download for your new request Extract the downloaded file Open index.html in the root of the extracted file location Confirm you can expand/collapse multiple levels of navigation successfully (eg expanding a child node does not collapse the parent) Regression test (see MDL-69559 and MDL-70033 ) Enable course content download in a course Switch to Classic theme From Course administration click on Download course content with your mouse Confirm Download course content modal appears Click Download and confirm down browser prompts to download archive Using your keyboard to navigate the Course administration tree press Enter on the Download course content link Confirm modal appears and you can download file Using your keyboard to navigate the Course administration tree press Space on the Download course content link Confirm modal appears and you can download file

      Exporting user data with the privacy tool since 3.10 produces a file whose tree navigation has become quite difficult to use - when you try to expand sub-nodes, the tree collapses back to the current root node (you then have to re-expand the root node to get back to the sub-node you were initially trying to navigate to)

      Reverting part of this commit from MDL-69559 allows the exported file navigation to become functional again - looking at the history, it appears that subsequent changes to the same file in MDL-70033 may have rendered the initial change obsolete. At least I couldn't reproduce what appears to be the problem that the initial change was trying to solve (using Classic and downloading course content)

      michaelh / dobedobedoh - interested to hear your thoughts, as the original authors?

        1. 0001-MDL-70580-core-Tree-nodes-should-check-if-they-were-.patch
          8 kB
        2. image-2021-01-13-11-34-32-418.png
          image-2021-01-13-11-34-32-418.png
          174 kB

            dobedobedoh Andrew Lyons
            pholden Paul Holden
            Michael Hawkins Michael Hawkins
            Jun Pataleta Jun Pataleta
            Janelle Barcega Janelle Barcega
            Votes:
            0 Vote for this issue
            Watchers:
            8 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 4 hours, 45 minutes
                4h 45m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.