Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-70585

Downloaded course content unbrowseable for some activity names

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      1. Login as admin
      2. Navigate to Courses > Download course content in site administration
      3. Enable Download course content feature available
      4. Create a new course, setting Enable download course content to Yes
      5. Add two URL resources to the course, with the following names:
        • "Oh no đŸ„”"
        • "This is quite a long title and is likely to exceed some limit"
      6. In the course Actions menu select Download course content
      7. Extract the downloaded archive
      8. Open the index.html file in the extracted location
      9. Confirm you can navigate to each of the URL resources from the index page
      Show
      Login as admin Navigate to Courses > Download course content in site administration Enable Download course content feature available Create a new course, setting Enable download course content to Yes Add two URL resources to the course, with the following names: "Oh no đŸ„”" "This is quite a long title and is likely to exceed some limit" In the course Actions menu select Download course content Extract the downloaded archive Open the index.html file in the extracted location Confirm you can navigate to each of the URL resources from the index page
    • Affected Branches:
      MOODLE_310_STABLE
    • Fixed Branches:
      MOODLE_310_STABLE
    • Pull 3.10 Branch:
      MDL-70585-310
    • Pull 3.11 Branch:
      MDL-70585-311
    • Pull Master Branch:

      Description

      On some systems (e.g. Ubuntu Linux at least for me), when the downloaded course content contains activities with unicode characters in their names the zip archive won't work correctly - this leads to broken links

      This is somewhat exacerbated by the zipwriter class using such a character to truncate long paths

      e.g. for the following exported course content Test_course_1610007782.zip - this is how the Zip structure is displayed/extracted on an affected system:

      There's also this note in the ZipStream repository regarding the same issue: https://github.com/maennchen/ZipStream-PHP/issues/146

        Attachments

        1. MDL-70585.jpg
          51 kB
          Anna Carissa Sadia
        2. MDL-70585.png
          54 kB
          Paul Holden
        3. MDL-70585 Before - After.png
          81 kB
          Paul Holden
        4. MDL-70585 chars.png
          8 kB
          Simey Lameze
        5. MDL-70585 dirname fixed.png
          9 kB
          Simey Lameze

          Issue Links

            Activity

              People

              Assignee:
              pholden Paul Holden
              Reporter:
              pholden Paul Holden
              Peer reviewer:
              Simey Lameze Simey Lameze
              Integrator:
              VĂ­ctor DĂ©niz FalcĂłn VĂ­ctor DĂ©niz FalcĂłn
              Tester:
              Anna Carissa Sadia Anna Carissa Sadia
              Participants:
              Component watchers:
              Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona)
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                8/Mar/21

                  Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 5 hours, 54 minutes
                  5h 54m