Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-70625

whitespace in the id field of the calendar block

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Test 1 (regression test copied from MDL-60125):

      1. Open the main calendar
      2. Add a calendar event
        1. Confirm the month reloaded to show the correct month with the new event
      3. Drag/drop a calendar event
        1. Confirm the month reloaded to show the correct month with the new event
      4. Drag/drop a calendar event to a different month
        1. Confirm the month reloaded to show the correct month with the new event
      5. Use the navigation to move forward a month
        1. Confirm the month changed
      6. Reload the page
        1. Confirm that the same month is still shown
      7. Move forward a few more months
        1. Confirm the month changed each time
      8. Move back a few months
        1. Confirm the month changed each time
      9. Click the "Calendar" link in the breadcrumbs
      10. Change back and forth month a few times
        1. Confirm the month changed each time
      11. Open your dashboard and add the calendar block
      12. Use the navigation to move forward some months
        1. Confirm the month changed each time
      13. Use the navigation to move back some months
        1. Confirm the month changed each time
      14. Open a course and add the calendar block
      15. Use the navigation to move forward some months
        1. Confirm the month changed each time
      16. Use the navigation to move back some months
        1. Confirm the month changed each time

      Test 2:

      1. Install the Hijri calendar type (https://github.com/rezaies/moodle-calendartype_hijri)

        git clone https://github.com/rezaies/moodle-calendartype_hijri calendar/type/hijri

      2. Log in as admin
      3. From the user menu, go to the preferences page, and then go to "Calendar preferences"
      4. Set your preferred calendar to Hijri
      5. Go to the calendar page
      6. Verify that there is no error on the page
      Show
      Test 1 (regression test copied from  MDL-60125 ): Open the main calendar Add a calendar event Confirm the month reloaded to show the correct month with the new event Drag/drop a calendar event Confirm the month reloaded to show the correct month with the new event Drag/drop a calendar event to a different month Confirm the month reloaded to show the correct month with the new event Use the navigation to move forward a month Confirm the month changed Reload the page Confirm that the same month is still shown Move forward a few more months Confirm the month changed each time Move back a few months Confirm the month changed each time Click the " Calendar " link in the breadcrumbs Change back and forth month a few times Confirm the month changed each time Open your dashboard and add the calendar block Use the navigation to move forward some months Confirm the month changed each time Use the navigation to move back some months Confirm the month changed each time Open a course and add the calendar block Use the navigation to move forward some months Confirm the month changed each time Use the navigation to move back some months Confirm the month changed each time Test 2: Install the Hijri calendar type ( https://github.com/rezaies/moodle-calendartype_hijri ) git clone https: //github.com/rezaies/moodle-calendartype_hijri calendar/type/hijri Log in as admin From the user menu, go to the preferences page, and then go to "Calendar preferences" Set your preferred calendar to Hijri Go to the calendar page Verify that there is no error on the page
    • Affected Branches:
      MOODLE_310_STABLE
    • Fixed Branches:
      MOODLE_310_STABLE, MOODLE_39_STABLE
    • Pull from Repository:
    • Pull 3.9 Branch:
    • Pull 3.10 Branch:
      MDL-70625-310
    • Pull 3.11 Branch:
      MDL-70625-311
    • Pull Master Branch:
      MDL-70625-master

      Description

      After MDL-60125, mini calendars uses the following for the id attribute. The issue is date.month is the month's name and in some languages it may contain spaces.

       

      calendar-month-{{date.year}}-{{date.month}}-{{uniqid}}
      

       

        Attachments

          Activity

            People

            Assignee:
            rezaie9 Shamim Rezaie
            Reporter:
            rezaie9 Shamim Rezaie
            Peer reviewer:
            Simey Lameze Simey Lameze
            Integrator:
            Sara Arjona (@sarjona) Sara Arjona (@sarjona)
            Tester:
            Anna Carissa Sadia Anna Carissa Sadia
            Participants:
            Component watchers:
            Andrew Lyons, Dongsheng Cai, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              8/Mar/21

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 3 hours, 32 minutes
                3h 32m