[MDL-70649] Allow plugins to augment the cURL security helper via callback - Moodle Tracker

XML

Word

Printable

Details

Type: Improvement
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 3.11
Fix Version/s: 3.11
Component/s: Administration
Labels:

Affected Branches:
MOODLE_311_STABLE
Fixed Branches:
MOODLE_311_STABLE
Pull from Repository:
https://github.com/xuangui2018/moodle
Pull 3.11 Branch:
~~MDL-70649~~-M311
Pull 3.11 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_311_STABLE...xuangui2018:MDL-70649-M311
Pull Main Branch:
~~MDL-70649~~-alternative-security-helper
Pull Main Diff URL:
https://github.com/moodle/moodle/compare/master...xuangui2018:MDL-70649-alternative-security-helper
Testing Instructions:
Hide

1) To aid in testing install this tool_curlmanager plugin which implements the callback:

git clone git@github.com:catalyst/moodle-tool_curlmanager.git admin/tool/curlmanager

2) Place the attached 'testcurl.php' file into your web root and run it

php testcurl.php

3) Visit this report page

http://moodle.local/admin/tool/curlmanager/report.php

4) Confirm you see both the original url ford.com and www.ford.com which is the url it redirected to as both urls should pass through the security helper
Show
1) To aid in testing install this tool_curlmanager plugin which implements the callback: git clone git@github.com:catalyst/moodle-tool_curlmanager.git admin/tool/curlmanager 2) Place the attached 'testcurl.php' file into your web root and run it php testcurl.php 3) Visit this report page http://moodle.local/admin/tool/curlmanager/report.php 4) Confirm you see both the original url ford.com and www.ford.com which is the url it redirected to as both urls should pass through the security helper

Description

The use case here is allowing a plugin to instrument or replace the curl proxy security layer

Something along the lines of

$CFG->alternative_security_helper = 'tool_foo_bar';

https://github.com/moodle/moodle/blob/master/lib/filelib.php#L3108-L3113

Attachments

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

MDL-70649.PNG
106 kB
15/Apr/21 2:03 PM
testcurl.php
0.2 kB
12/Apr/21 5:13 PM

Issue Links

caused a regression

MDL-73827 URL blocked during OBv2.1 user authentication

Closed

Activity

People

Assignee:: Xuan Gui

Reporter:: Brendan Heywood

Peer reviewer:: Peter Burnett

Integrator:: Jake Dallimore

Tester:: Gladys Basiana

Participants:: Brendan Heywood, CiBoT, Gladys Basiana, Jake Dallimore, Peter Burnett, Sara Arjona (@sarjona), Xuan Gui

Votes:: 0 Vote for this issue

Watchers:: 7 Start watching this issue

Dates

Created:: 18/Jan/21 2:17 PM

Updated:: 10/Feb/22 2:13 AM

Resolved:: 16/Apr/21 11:35 PM

Fix Release Date:: 17/May/21

Time Tracking

Estimated:

Not Specified

Remaining:

0m

Logged:

3h 35m