Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-70649

Allow plugins to augment the cURL security helper via callback

XMLWordPrintable

    • MOODLE_311_STABLE
    • MOODLE_311_STABLE
    • MDL-70649-alternative-security-helper
    • Hide

      1) To aid in testing install this tool_curlmanager plugin which implements the callback:

      git clone git@github.com:catalyst/moodle-tool_curlmanager.git admin/tool/curlmanager
      

      2) Place the attached 'testcurl.php' file into your web root and run it

      php testcurl.php 

      3) Visit this report page

      http://moodle.local/admin/tool/curlmanager/report.php

      4) Confirm you see both the original url ford.com and www.ford.com which is the url it redirected to as both urls should pass through the security helper 

       

      Show
      1) To aid in testing install this tool_curlmanager plugin which implements the callback: git clone git@github.com:catalyst/moodle-tool_curlmanager.git admin/tool/curlmanager 2) Place the attached 'testcurl.php' file into your web root and run it php testcurl.php 3) Visit this report page http://moodle.local/admin/tool/curlmanager/report.php 4) Confirm you see both the original url ford.com and www.ford.com  which is the url it redirected to as both urls should pass through the security helper   

      The use case here is allowing a plugin to instrument or replace the curl proxy security layer

      Something along the lines of 

      $CFG->alternative_security_helper = 'tool_foo_bar';

      https://github.com/moodle/moodle/blob/master/lib/filelib.php#L3108-L3113

       

        1. MDL-70649.PNG
          MDL-70649.PNG
          106 kB
        2. testcurl.php
          0.2 kB

            xuangui Xuan Gui
            brendanheywood Brendan Heywood
            Peter Burnett Peter Burnett
            Jake Dallimore Jake Dallimore
            Gladys Basiana Gladys Basiana
            Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 3 hours, 35 minutes
                3h 35m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.