[MDL-70726] Behat: should_not_exist function does not work correctly - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Critical
Resolution: Fixed
Affects Version/s: 3.5.16, 3.7 regressions, 3.8.7, 3.9.4, 3.10.1
Fix Version/s: 3.5.18, 3.8.9, 3.9.6, 3.10.3
Component/s: Automated functional tests (behat), Course, H5P
Labels:
- ci
- triaged

Affected Branches:
MOODLE_310_STABLE, MOODLE_35_STABLE, MOODLE_38_STABLE, MOODLE_39_STABLE
Fixed Branches:
MOODLE_310_STABLE, MOODLE_35_STABLE, MOODLE_38_STABLE, MOODLE_39_STABLE
Pull from Repository:
https://github.com/NashTechOpenUniversity/moodle
Pull 3.9 Branch:
~~MDL-70726~~-3.9
Pull 3.9 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_39_STABLE...NashTechOpenUniversity:MDL-70726-3.9?expand=1
Pull 3.11 Branch:
~~MDL-70726~~-3.11
Pull 3.11 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_311_STABLE...NashTechOpenUniversity:MDL-70726-3.11?expand=1
Pull Main Branch:
~~MDL-70726~~-master
Pull Main Diff URL:
https://github.com/moodle/moodle/compare/master...NashTechOpenUniversity:MDL-70726-master?expand=1
Testing Instructions:
Hide

Regression tests

Ensure that Behat continues to pass

Integration tests

Open admin/tool/behat/tests/behat/keyboard.feature in your editor

Find the first `I click on "Log in" "link"` line

After that line add:

Then "Username" "field" should not exist

Run the test

Confirm that there is a failure because the "Username" field does exist
Show
Regression tests Ensure that Behat continues to pass Integration tests Open admin/tool/behat/tests/behat/keyboard.feature in your editor Find the first ` I click on "Log in" "link" ` line After that line add: Then "Username" "field" should not exist Run the test Confirm that there is a failure because the "Username" field does exist

Description

The function should_not_exist in lib/tests/behat/behat_general.php is not worked correctly.

The Behat step related to this function: @Then /^"(?P<element_string>(?:[^"]|
"))" "(?P<selector_string>[^"])" should not exist will be always passed even the element is exist.

It's just a simple fix, remove the return in the try block will fix the issue.

https://github.com/moodle/moodle/blob/7fa836cf3680c1d041daae6dd5bad4c246b5f85f/lib/tests/behat/behat_general.php#L1012

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

image-2021-03-11-12-42-50-287.png
119 kB
11/Mar/21 12:42 PM
Remove a site backpack.PNG
179 kB
02/Feb/21 12:37 PM
Upload users setting their user theme.PNG
62 kB
02/Feb/21 12:37 PM

Issue Links

Testing discovered

MDL-70813 User tour tabindex updated incorrectly by aria-show/hide

Open

Activity

People

Assignee:: Thong Bui

Reporter:: Huong Nguyen

Peer reviewer:: Andrew Lyons

Integrator:: Eloy Lafuente (stronk7)

Tester:: Janelle Barcega

Participants:: Amaia Anabitarte, Andrew Lyons, CiBoT, Eloy Lafuente (stronk7), Huong Nguyen, Janelle Barcega, Thong Bui, Tim Hunt, ToBiC

Votes:: 1 Vote for this issue

Watchers:: 8 Start watching this issue

Dates

Created:: 28/Jan/21 11:27 AM

Updated:: 12/Mar/21 1:04 AM

Resolved:: 12/Mar/21 1:04 AM

Fix Release Date:: 25/Mar/21

Time Tracking

Estimated:

Not Specified

Remaining:

Logged:

2h 56m

Details

Regression tests

Integration tests

Description

Attachments

Attachments

Issue Links

Activity

People

Dates

Time Tracking