3.5.16, 3.8.7, 3.9.4, 3.10.1, 3.11, 4.0
MOODLE_310_STABLE, MOODLE_311_STABLE, MOODLE_35_STABLE, MOODLE_38_STABLE, MOODLE_39_STABLE, MOODLE_400_STABLE
MDL-66979 it was detected that all the behat:get_timeout() family of functions are expected to be seconds.
In the other side, web drivers like the times in miliseconds.
Hence, codebase is plagued with calls like this (just a example):
$this->getSession()->wait(self::get_timeout() * 1000, self::PAGE_READY_JS);
But this is tricky and easy so forget, because there are also calls like this:
So we are just passing a few miliseconds sometimes!
So, this issue is about to:
- Review that all uses are consistent.
- Consider if, maybe we should change to miliseconds by default.
- Consider if we should add some protection so, for example, if we continue using seconds and 30000 is passed something is wrong or, if we decide to change to miliseconds and only 100 are passed, then something is also wrong. This would help to detect bad uses in the future