[MDL-70734] Random behat failures with tool_httpsreplace scenarios (timeout) - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Blocker
Resolution: Fixed
Affects Version/s: 3.9.4, 3.10.1, 3.11, 4.0
Fix Version/s: 3.9.5, 3.10.2
Component/s: Automated functional tests (behat)
Labels:
- ci

Affected Branches:
MOODLE_310_STABLE, MOODLE_311_STABLE, MOODLE_39_STABLE, MOODLE_400_STABLE
Fixed Branches:
MOODLE_310_STABLE, MOODLE_39_STABLE
Epic Link:
CI random failures
Pull from Repository:
git://github.com/andrewnicols/moodle.git
Pull 3.9 Branch:
~~MDL-70734~~-39
Pull 3.9 Diff URL:
https://github.com/andrewnicols/moodle/compare/0f1f18d8a4...MDL-70734-39
Pull 3.11 Branch:
~~MDL-70734~~-311
Pull 3.11 Diff URL:
https://github.com/andrewnicols/moodle/compare/fb9419ec0b...MDL-70734-311
Pull Master Branch:
~~MDL-70734~~-master
Pull Master Diff URL:
https://github.com/andrewnicols/moodle/compare/9dabd071fe...MDL-70734-master

Testing Instructions:

Download the attached ~~MDL-70734~~.patch file to the moodle site root folder and run the command git apply ~~MDL-70734~~.patch in order to apply the following patch:

diff --git a/admin/tool/httpsreplace/classes/url_finder.php b/admin/tool/httpsreplace/

classes/url_finder.php

index 8dc141616b9..95384e9c5e1 100644

--- a/admin/tool/httpsreplace/classes/url_finder.php

+++ b/admin/tool/httpsreplace/classes/url_finder.php

@@ -151,6 +151,7 @@ class url_finder {

         $numberoftables = count($tables);

         $tablenumber = 0;

+        sleep(31);

         foreach ($tables as $table) {

             if ($progress) {

                 $progress->update($tablenumber, $numberoftables, get_string('searchin

g', 'tool_httpsreplace', $table));

Run the httpsreplace (--tags '@tool_httpsreplace') tests. Note that there will be a pause of 31 seconds with the browser doing nothing, be patient:
mdk behat -r -t tool_httpsreplace
- Confirm they now pass

Show

Download the attached MDL-70734 .patch file to the moodle site root folder and run the command git apply MDL-70734 .patch in order to apply the following patch: diff --git a/admin/tool/httpsreplace/classes/url_finder.php b/admin/tool/httpsreplace/ classes/url_finder.php index 8dc141616b9..95384e9c5e1 100644 --- a/admin/tool/httpsreplace/classes/url_finder.php +++ b/admin/tool/httpsreplace/classes/url_finder.php @@ -151,6 +151,7 @@ class url_finder { $numberoftables = count($tables); $tablenumber = 0; + sleep(31); foreach ($tables as $table) { if ($progress) { $progress->update($tablenumber, $numberoftables, get_string('searchin g', 'tool_httpsreplace', $table)); Run the httpsreplace ( --tags '@tool_httpsreplace' ) tests. Note that there will be a pause of 31 seconds with the browser doing nothing, be patient: mdk behat -r -t tool_httpsreplace Confirm they now pass

Description

This is a sister of ~~MDL-70014~~ and maybe the same solution will fix both.

In any case, this has started to happen immediately after switching to the w3c webdrivers and it was not happening before, so maybe deserves a little bit of research to confirm why that's happening. That's the reason to create it separate from the linked issue.

It happens with slow runs (slow databases or super-busy workers). And with it fails, usually there are 2 scenarios involved.

Link: https://ci.moodle.org/job/W39.03.05%20-%20Behat%20-%20Chrome%20+%20Oracle/146/

Output:

001 Scenario: Go to the HTTPS replace report screen. Make sure broken domains are reported. # /var/www/html/admin/tool/httpsreplace/tests/behat/httpsreplace.feature:15

      And I press "Continue"                                                                # /var/www/html/admin/tool/httpsreplace/tests/behat/httpsreplace.feature:18

        Curl error thrown for http POST to /session/77c3b7197af10c36eebebba7650a34fc/element/38fc55ab-deb0-4e28-b941-f2cf1746c3a2/click

        Operation timed out after 30001 milliseconds with 0 bytes received (Facebook\WebDriver\Exception\WebDriverCurlException)

002 Scenario: Use the find and replace tool. # /var/www/html/admin/tool/httpsreplace/tests/behat/httpsreplace.feature:22

      And I press "Continue"                 # /var/www/html/admin/tool/httpsreplace/tests/behat/httpsreplace.feature:25

        Curl error thrown for http POST to /session/ea0da79318551585f3a26ce8fd0b7822/element/c1fa3f4d-3e69-4f3b-a402-9df04bea1e81/click

        Operation timed out after 30001 milliseconds with 0 bytes received (Facebook\WebDriver\Exception\WebDriverCurlException)

2 scenarios (2 failed)

17 steps (10 passed, 2 failed, 5 skipped)

1m32.28s (47.18Mb)

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

image-2021-02-03-12-07-40-140.png
47 kB
03/Feb/21 12:07 PM

Issue Links

Discovered while testing

MDL-66979 Switch all the behat testing to the new W3C drivers

Closed

has been marked as being related by

MDL-70014 Random behat failures with tool_customlang scenarios (timeout)

Closed

MDL-75223 Problems with Oracle 21 (behat testing failures)

Closed

Activity

People

Assignee:: Andrew Lyons

Reporter:: Eloy Lafuente (stronk7)

Peer reviewer:: Eloy Lafuente (stronk7)

Integrator:: Sara Arjona (@sarjona)

Tester:: Janelle Barcega

Participants:: Andrew Lyons, CiBoT, Eloy Lafuente (stronk7), Janelle Barcega, Sara Arjona (@sarjona)

Component watchers:

Votes:: 1 Vote for this issue

Watchers:: 4 Start watching this issue

Dates

Created:: 29/Jan/21 2:00 AM

Updated:: 22/Aug/22 3:46 PM

Resolved:: 04/Feb/21 10:19 PM

Fix Release Date:: 8/Mar/21

Time Tracking

Estimated:

Not Specified

Remaining:

Logged:

1d 2h 25m