Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-70802

core/templates does not set default component

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.9.4, 3.10.1, 3.11, 4.0
    • Fix Version/s: 3.9.7, 3.10.4
    • Component/s: JavaScript
    • Labels:
    • Testing Instructions:
      Hide

      Behat will test most of this for regressions. Many things will be fixed which we didn't know were broken (mostly realted to caching)

      1. Login as admin
      2. Navigate to Site admin -> Competencies -> Competency frameworks
      3. Create a new framewokr
      4. WIthin that framework create a couple of competencies
      5. Select one of the competencies you just created
      6. Open the "Edit" menu
        1. Confirm that all of the icons for the menu options are black
      7. Inspect the icons
        1. *Confirm that they are <i> icons and not <img>
      8. Choose the "Move up" or "Move down" link
      9. Open the "Edit" menu
        1. Confirm that all of the icons for the menu options are black
      10. Inspect the icons
        1. *Confirm that they are <i> icons and not <img>
      Show
      Behat will test most of this for regressions. Many things will be fixed which we didn't know were broken (mostly realted to caching) Login as admin Navigate to Site admin -> Competencies -> Competency frameworks Create a new framewokr WIthin that framework create a couple of competencies Select one of the competencies you just created Open the "Edit" menu Confirm that all of the icons for the menu options are black Inspect the icons *Confirm that they are <i> icons and not <img> Choose the "Move up" or "Move down" link Open the "Edit" menu Confirm that all of the icons for the menu options are black Inspect the icons *Confirm that they are <i> icons and not <img>
    • Affected Branches:
      MOODLE_310_STABLE, MOODLE_311_STABLE, MOODLE_39_STABLE, MOODLE_400_STABLE
    • Fixed Branches:
      MOODLE_310_STABLE, MOODLE_39_STABLE
    • Pull 3.9 Branch:
    • Pull 3.10 Branch:
      MDL-70802-310
    • Pull 3.11 Branch:
      MDL-70802-311
    • Pull Master Branch:
      MDL-70802-master

      Description

      Moodle typically normalises the component such that '', 'moodle' and 'core' all have the same meaning.

      There are some situations in core/templates where this does not happen. This can lead to calls not being cached, and font icons not being available

        Attachments

          Activity

            People

            Assignee:
            dobedobedoh Andrew Lyons
            Reporter:
            dobedobedoh Andrew Lyons
            Peer reviewer:
            Mathew May Mathew May
            Integrator:
            Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
            Tester:
            Anna Carissa Sadia Anna Carissa Sadia
            Participants:
            Component watchers:
            Andrew Lyons, Dongsheng Cai, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              10/May/21

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 4 hours, 50 minutes
                4h 50m