Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-70806

Random behat failure with H5P content with uninstalled libraries

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.11, 4.0
    • Fix Version/s: 3.11
    • Component/s: H5P
    • Testing Instructions:
      Hide

      Behat test:

      1. Execute contentbank/contenttype/h5p/tests/behat/teacher_upload_content.feature on chrome and firefox
      2. Check the test pass in both browsers.

      Glitch test:

      1. Login as admin and create an H5P activity in a course using: documentation-tool-3022.h5p
      2. Access the activity to deploy the content and verify it opens without any error.
      3. Check that after refreshing several times the page the activity content appears once loaded, with no glitchy effect resizing while the content is allocating (or only happens if the instance is overloaded).
      4. Go to Site administration -> H5P -> Manage H5P content types and ensure "Find the Hotspot" is not present in the installed H5P content types
        1. If "Find the Hotspot" is present, detele it with the "delete version" icon.
      5. Login as a teacher and create a H5P activity using find-the-hotspot-3024.h5p
      6. Access the activity
      7. Check the content cannot deploy and the error message is visible without any scroll bar in the iframe.
      Show
      Behat test: Execute contentbank/contenttype/h5p/tests/behat/teacher_upload_content.feature on chrome and firefox Check the test pass in both browsers. Glitch test: Login as admin and create an H5P activity in a course using:  documentation-tool-3022.h5p Access the activity to deploy the content and verify it opens without any error. Check that after refreshing several times the page the activity content appears once loaded, with no glitchy effect resizing while the content is allocating (or only happens if the instance is overloaded). Go to Site administration -> H5P -> Manage H5P content types and ensure "Find the Hotspot" is not present in the installed H5P content types If "Find the Hotspot" is present, detele it with the "delete version" icon. Login as a teacher and create a H5P activity using  find-the-hotspot-3024.h5p Access the activity Check  the content cannot deploy and the error message is visible without any scroll bar in the iframe.
    • Affected Branches:
      MOODLE_311_STABLE, MOODLE_400_STABLE
    • Fixed Branches:
      MOODLE_311_STABLE
    • Pull 3.11 Branch:
      MDL-70806-311
    • Pull Master Branch:
      MDL-70806-master
    • Sprint:
      Moppies Kanban

      Description

      After MDL-70634 landed, some random errors start appearing for the scenario "Teachers can not see existing contents when libraries are not installed".

      Looking at the logs of this manual run you can see that it has failed 2 times and it passed last one: https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/11463/:

      Started at 04-02-2021, 21:42
      ...................................................F
      --- Failed steps:
      001 Scenario: Teachers can not see existing contents when libraries are not installed # /var/www/html/contentbank/contenttype/h5p/tests/behat/teacher_upload_content.feature:101
       Then I should see "missing-required-library" # /var/www/html/contentbank/contenttype/h5p/tests/behat/teacher_upload_content.feature:145
       "missing-required-library" text was found but was not visible (Behat\Mink\Exception\ExpectationException)
      1 scenario (1 failed)
      52 steps (51 passed, 1 failed)
      0m57.61s (52.30Mb)
      

       It fails usually with Firefox.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              tusefomal Ferran Recio
              Reporter:
              sarjona Sara Arjona (@sarjona)
              Peer reviewer:
              Amaia Anabitarte Amaia Anabitarte
              Integrator:
              Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
              Tester:
              Anna Carissa Sadia Anna Carissa Sadia
              Participants:
              Component watchers:
              Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona)
              Votes:
              1 Vote for this issue
              Watchers:
              6 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                17/May/21

                  Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 1 day, 40 minutes
                  1d 40m