Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-70828

Add ability to switch off session lock debugging

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      1. Enable developer debugging: "Site administration > Development > Debugging" Debug messages - Developer.
      2. Edit config.php and add the following setting: $CFG->enable_read_only_sessions_debug = true;
      3. Open the error log: tail -f /var/log/apache2/error.log
      4. Visit any page in moodle.
      5. Observe there is an error similar to:

        defined READ_ONLY_SESSION but the following SESSION attributes were changed: 
        

      6. Edit config.php again and remove the setting.
      7. Open the error log: tail -f /var/log/apache2/error.log
      8. Visit any page in moodle.
      9. Observe there is no longer an error.
      Show
      Enable developer debugging: "Site administration > Development > Debugging" Debug messages - Developer. Edit config.php and add the following setting: $CFG->enable_read_only_sessions_debug = true; Open the error log: tail -f /var/log/apache2/error.log Visit any page in moodle. Observe there is an error similar to: defined READ_ONLY_SESSION but the following SESSION attributes were changed: Edit config.php again and remove the setting. Open the error log: tail -f /var/log/apache2/error.log Visit any page in moodle. Observe there is no longer an error.
    • Affected Branches:
      MOODLE_311_STABLE, MOODLE_400_STABLE
    • Fixed Branches:
      MOODLE_311_STABLE
    • Pull from Repository:
    • Pull 3.11 Branch:
      MDL-70828-311
    • Pull Master Branch:
      MDL-70828-master
    • Story Points:
      1
    • Sprint:
      4.0 holding pattern 12

      Description

      I understand that it is very useful to be able to debug session lock problems, but now with a vanilla install of Moodle accessing any page will result in a session lock message being sent to the error log.

      In most situations I'm never using the read only session and this adds more entries into the error log that makes it difficult to debug other problems.

      Can we introduce a setting to disable this?

        Attachments

        1. MDL-70828-311-1.png
          MDL-70828-311-1.png
          46 kB
        2. MDL-70828-311-2.png
          MDL-70828-311-2.png
          58 kB
        3. MDL-70828-master-1.png
          MDL-70828-master-1.png
          57 kB
        4. MDL-70828-master-2.png
          MDL-70828-master-2.png
          53 kB

          Issue Links

            Activity

              People

              Assignee:
              abgreeve Adrian Greeve
              Reporter:
              abgreeve Adrian Greeve
              Peer reviewer:
              Peter Dias Peter Dias
              Integrator:
              Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
              Tester:
              Michael Hawkins Michael Hawkins
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan
              Votes:
              2 Vote for this issue
              Watchers:
              7 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                17/May/21

                  Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 3 hours, 20 minutes
                  3h 20m