[MDL-70828] Add ability to switch off session lock debugging - Moodle Tracker

XML

Word

Printable

Details

Type: Improvement
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 3.11, 4.0
Fix Version/s: 3.11
Component/s: Other
Labels:
- ci
- hqteam_alpha
- release_notes
- triaged

Affected Branches:
MOODLE_311_STABLE, MOODLE_400_STABLE
Fixed Branches:
MOODLE_311_STABLE
Pull from Repository:
git://github.com/abgreeve/moodle.git
Pull 3.11 Branch:
~~MDL-70828~~-311
Pull 3.11 Diff URL:
https://github.com/abgreeve/moodle/compare/af0040445a...MDL-70828-311
Pull Main Branch:
~~MDL-70828~~-master
Pull Main Diff URL:
https://github.com/abgreeve/moodle/compare/a93828a188...MDL-70828-master
Testing Instructions:
Hide

Enable developer debugging: "Site administration > Development > Debugging" Debug messages - Developer.

Edit config.php and add the following setting: $CFG->enable_read_only_sessions_debug = true;

Open the error log: tail -f /var/log/apache2/error.log

Visit any page in moodle.

Observe there is an error similar to:

defined READ_ONLY_SESSION but the following SESSION attributes were changed:

Edit config.php again and remove the setting.

Open the error log: tail -f /var/log/apache2/error.log

Visit any page in moodle.

Observe there is no longer an error.
Show
Enable developer debugging: "Site administration > Development > Debugging" Debug messages - Developer. Edit config.php and add the following setting: $CFG->enable_read_only_sessions_debug = true; Open the error log: tail -f /var/log/apache2/error.log Visit any page in moodle. Observe there is an error similar to: defined READ_ONLY_SESSION but the following SESSION attributes were changed: Edit config.php again and remove the setting. Open the error log: tail -f /var/log/apache2/error.log Visit any page in moodle. Observe there is no longer an error.

Story Points:
1
Sprint:
4.0 holding pattern 12

Description

I understand that it is very useful to be able to debug session lock problems, but now with a vanilla install of Moodle accessing any page will result in a session lock message being sent to the error log.

In most situations I'm never using the read only session and this adds more entries into the error log that makes it difficult to debug other problems.

Can we introduce a setting to disable this?

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

MDL-70828-311-1.png
46 kB
25/Feb/21 12:18 PM
MDL-70828-311-2.png
58 kB
25/Feb/21 12:18 PM
MDL-70828-master-1.png
57 kB
25/Feb/21 12:18 PM
MDL-70828-master-2.png
53 kB
25/Feb/21 12:18 PM

Issue Links

has a non-specific relationship to

MDL-70819 course/rest.php defined READ_ONLY_SESSION but changed: $SESSION->navcache

Closed

MDL-68608 Improve the readonly session debugging message

Closed

has been marked as being related by

MDL-72670 $CFG->enable_read_only_sessions_debug produces false positives

Closed

MDL-64449 Add debug feature to expose code issues with session locks

Closed

Activity

People

Assignee:: Adrian Greeve

Reporter:: Adrian Greeve

Peer reviewer:: Peter Dias

Integrator:: Eloy Lafuente (stronk7)

Tester:: Michael Hawkins

Participants:: Adrian Greeve, Brendan Heywood, CiBoT, Eloy Lafuente (stronk7), Michael Hawkins, Nadav Kavalerchik, Paul Holden, Peter Dias

Votes:: 2 Vote for this issue

Watchers:: 7 Start watching this issue

Dates

Created:: 09/Feb/21 8:07 AM

Updated:: 05/Oct/21 9:26 AM

Resolved:: 26/Feb/21 2:15 PM

Fix Release Date:: 17/May/21

Time Tracking

Estimated:

Remaining:

Logged:

3h 20m