Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-70844

Update the secondary navigation view to send site administration information in tab form.

XMLWordPrintable

    • MOODLE_311_STABLE
    • MOODLE_400_STABLE
    • MDL-70844-master
    • Hide

      This is hard to test.

      Setup:

      1. Pull in the branch https://github.com/peterRd/moodle/tree/MDL-70888-master_bas_changes_1 which includes Bas' changes from 70888 and this patch.

        git pull https://github.com/peterRd/moodle MDL-70888-master_bas_changes_1

        Alternately, if any conflicts pop up, checkout the branch

        git fetch https://github.com/peterRd/moodle MDL-70888-master_bas_changes_1
        git checkout FETCH_HEAD

      Testing instructions:

      1. Go to the Site admin by entering the following in the address bar{{http://master/admin/index.php}}
      2. When in site administration on the main index page, open up the browser inspector
      3. Inspect the tabs
      4. Confirm they have anchors in their href attrib. 
      5. Click on the nested setting pages
      6. Confirm they redirect to the correct page
      7. Confirm the secondary nav(the tabs on the site admin page) now show up as links with the anchors appended.
        e.g. if you're on http://master/admin/settings.php?section=analyticssite, the tabs now have links e.g. Site Administration - http://master/admin/search.php#linkroot
      8. Click on the different tabs
      9. Confirm they redirect correctly to the relevant page(site admin index/search page) and the corresponding tab.

      Note: Replace 'master' with your localhost

      Show
      This is hard to test. Setup: Pull in the branch https://github.com/peterRd/moodle/tree/MDL-70888-master_bas_changes_1  which includes Bas' changes from 70888 and this patch. git pull https://github.com/peterRd/moodle MDL-70888 -master_bas_changes_1 Alternately, if any conflicts pop up, checkout the branch git fetch  https://github.com/peterRd/moodle MDL-70888 -master_bas_changes_1 git checkout FETCH_HEAD Testing instructions: Go to the Site admin by entering the following in the address bar{{ http://master/admin/index.php }} When in site administration on the main index page, open up the browser inspector Inspect the tabs Confirm they have anchors in their href attrib.  Click on the nested setting pages Confirm they redirect to the correct page Confirm the secondary nav(the tabs on the site admin page) now show up as links with the anchors appended. e.g. if you're on http://master/admin/settings.php?section=analyticssite , the tabs now have links e.g. Site Administration - http://master/admin/search.php#linkroot Click on the different tabs Confirm they redirect correctly to the relevant page(site admin index/search page) and the corresponding tab. Note: Replace 'master' with your localhost
    • 3
    • 4.0 Navigation blitz

      Currently site administration information in the secondary navigation view is taken from the navigation tree. This needs to be updated to use the information that is sent to the template, that is used in the boost theme, to show the initial site administration page.

      We want the current boost behaviour in the new navigation system.

        1. anchors.png
          anchors.png
          83 kB
        2. links.png
          links.png
          38 kB

            peterdias Peter Dias
            abgreeve Adrian Greeve
            Mihail Geshoski Mihail Geshoski
            Andrew Lyons Andrew Lyons
            Victor Déniz Falcón Victor Déniz Falcón
            Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 2 hours, 36 minutes
                2h 36m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.