[MDL-70864] Problem with zip_packer under Windows - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: 3.9.4, 3.10.1, 3.11, 4.0
Fix Version/s: 3.9.7, 3.10.4
Component/s: Files API, Unit tests
Labels:
- ci
- triaged

Affected Branches:
MOODLE_310_STABLE, MOODLE_311_STABLE, MOODLE_39_STABLE, MOODLE_400_STABLE
Fixed Branches:
MOODLE_310_STABLE, MOODLE_39_STABLE
Pull from Repository:
git://github.com/mudrd8mz/moodle.git
Pull 3.9 Branch:
~~MDL-70864~~-39-zip_packer_windows
Pull 3.9 Diff URL:
https://github.com/mudrd8mz/moodle/compare/1c3b9af49a...MDL-70864-39-zip_packer_windows
Pull 3.11 Branch:
~~MDL-70864~~-311-zip_packer_windows
Pull 3.11 Diff URL:
https://github.com/mudrd8mz/moodle/compare/6f48b4ab71...MDL-70864-311-zip_packer_windows
Pull Master Branch:
~~MDL-70864~~-master-zip_packer_windows
Pull Master Diff URL:
https://github.com/mudrd8mz/moodle/compare/0a986fdf13...MDL-70864-master-zip_packer_windows
Testing Instructions:

Hide

N/A - covered by unit tests.

Show
N/A - covered by unit tests.

Description

It seems that something new has recently landed and it's causing windows unit tests to, consistently, fail.

Link: https://travis-ci.com/github/stronk7/moodle/jobs/482318828
Error:

There was 1 error:

1) core_files_zip_packer_testcase::test_zip_entry_path_having_folder_ending_with_dot

ZipArchive::extractTo(C:\Users\travis\roots\phpunitdata/localcache\dfb17e68-bf52-49d6-a8fc-4fa3d2bc002d\5e4ea5a9-6314-4ae1-b2dc-e34954fcfc62/target/README.): failed to open stream: Permission denied

C:\Users\travis\build\stronk7\moodle\lib\filestorage\zip_archive.php:276

C:\Users\travis\build\stronk7\moodle\lib\filestorage\zip_packer.php:371

C:\Users\travis\build\stronk7\moodle\lib\filestorage\tests\zip_packer_test.php:295

C:\Users\travis\build\stronk7\moodle\lib\phpunit\classes\advanced_testcase.php:80

To re-run:

 vendor/bin/phpunit --verbose "core_files_zip_packer_testcase" lib/filestorage/tests/zip_packer_test.php

This may be related with the changes accepted this week @ ~~MDL-70631~~

Attachments

Issue Links

has a non-specific relationship to

MDL-70519 test_get_file_writer() failures when running filtered tests

Open

is a regression caused by

MDL-70631 Poor performance of zip_packer::extract_to_pathname()

Closed

Activity

People

Assignee:: David Mudrák (@mudrd8mz)

Reporter:: Eloy Lafuente (stronk7)

Peer reviewer:: Jordi Pujol-Ahulló

Integrator:: Victor Déniz Falcón

Tester:: CiBoT

Participants:: CiBoT, David Mudrák (@mudrd8mz), Eloy Lafuente (stronk7), Jordi Pujol-Ahulló, Victor Déniz Falcón

Component watchers:: Matteo Scaramuccia, David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo

Votes:: 0 Vote for this issue

Watchers:: 5 Start watching this issue

Dates

Created:: 12/Feb/21 6:18 PM

Updated:: 07/May/21 11:35 PM

Resolved:: 07/May/21 11:35 PM

Fix Release Date:: 10/May/21

Time Tracking

Estimated:

Not Specified

Remaining:

Logged:

1d 6h