Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-70898

PHP 8.0: Private methods cannot be final as they are never overridden by other classes

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.10.1, 3.11, 4.0
    • Fix Version/s: 3.11
    • Component/s: General
    • Labels:

      Description

      PHP 8.0 shows a warning:

      PHP Warning:  Private methods cannot be final as they are never overridden by other classes
      

      See also https://php.watch/versions/8.0/final-private-function#final-private
      there is an exception for final private __construct() and there is one constructor like that in moodle still

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              marina Marina Glancy
              Reporter:
              marina Marina Glancy
              Peer reviewer:
              Amaia Anabitarte Amaia Anabitarte
              Integrator:
              Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
              Tester:
              CiBoT CiBoT
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                17/May/21

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 3 hours, 10 minutes
                  3h 10m