[MDL-70910] core_contentbank\external\rename_content is not using validated parameters - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 3.9.4, 3.10.1, 3.11, 4.0
Fix Version/s: 3.9.5, 3.10.2
Component/s: Content bank
Labels:
- ci
- triaged

Affected Branches:
MOODLE_310_STABLE, MOODLE_311_STABLE, MOODLE_39_STABLE, MOODLE_400_STABLE
Fixed Branches:
MOODLE_310_STABLE, MOODLE_39_STABLE
Pull from Repository:
git://github.com/dravek/moodle.git
Pull 3.9 Branch:
~~MDL-70910~~-39
Pull 3.9 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_39_STABLE...dravek:MDL-70910-39
Pull 3.11 Branch:
~~MDL-70910~~-311
Pull 3.11 Diff URL:
https://github.com/dravek/moodle/compare/MOODLE_311_STABLE...MDL-70910-311
Pull Master Branch:
~~MDL-70910~~-master
Pull Master Diff URL:
https://github.com/dravek/moodle/compare/master...MDL-70910-master
Difficulty:
Easy
Testing Instructions:
Hide

Go to Site Administration/Server/Tasks/Scheduled tasks

Find the task "Download available H5P content types from h5p.org" and click on "Run now"

Click "Run now" on the Confirm message

When Process is done click on the "Content bank" icon on the left navigation drawer.

Click on "Add" action button and select for example "Summary"

Set the Title as "Cool bananas", and click Save.

Click on the cog icon and select "Rename"

Set Content name to "Frozen oranges" and click "Rename".

You should see the message "The content has been renamed." and see that the name has been changed to "Frozen oranges".
Show
Go to Site Administration/Server/Tasks/Scheduled tasks Find the task "Download available H5P content types from h5p.org" and click on "Run now" Click "Run now" on the Confirm message When Process is done click on the "Content bank" icon on the left navigation drawer. Click on "Add" action button and select for example "Summary" Set the Title as "Cool bananas", and click Save. Click on the cog icon and select "Rename" Set Content name to "Frozen oranges" and click "Rename". You should see the message "The content has been renamed." and see that the name has been changed to "Frozen oranges".

Description

core_contentbank\external\rename_content execute method is using $contentid instead $params['contentid'] in some cases. For instance, here.

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

MDL-70910.jpg
11 kB
03/Mar/21 10:53 AM

Issue Links

Testing discovered

MDL-70941 Cannot rename content bank item to "0"

Closed

Activity

People

Assignee:: David Carrillo

Reporter:: Sara Arjona (@sarjona)

Peer reviewer:: Paul Holden

Integrator:: Eloy Lafuente (stronk7)

Tester:: Anna Carissa Sadia

Participants:: Anna Carissa Sadia, CiBoT, David Carrillo, Eloy Lafuente (stronk7), Paul Holden, Sara Arjona (@sarjona)

Component watchers:: Amaia Anabitarte, Carlos Escobedo, Laurent David, Mikel Martín Corrales, Sabina Abellan, Sara Arjona (@sarjona)

Votes:: 0 Vote for this issue

Watchers:: 4 Start watching this issue

Dates

Created:: 16/Feb/21 3:16 PM

Updated:: 05/Mar/21 11:37 PM

Resolved:: 05/Mar/21 11:37 PM

Fix Release Date:: 8/Mar/21

Time Tracking

Estimated:

Remaining:

Logged:

1h 5m